search

bramkragten / swipe-card

Card that allows you to swipe throught multiple cards for Home Assistant Lovelace
245 stars 36 forks source link

hold_action not working on glance card inside swipe card #7

Open kicker10BOG opened 4 years ago

kicker10BOG commented 4 years ago

I was playing around with views today and discovered that the hold_action fails on card (at least glance cards) inside a swipe card.

My assumption is that hold_action must be disabled on swipe cards to allow the swipe action. Is that correct?

It would be nice to be able to use the hold_action if possible.

Villhellm commented 4 years ago

So is this a will-not-fix? Closing this without explanation is asking for someone to open the same issue again.

bramkragten commented 4 years ago

Not sure why this was closed, most likely because it was fixed? Is this still an issue?

Might be closed by accident? 🤷‍♂️

Villhellm commented 4 years ago

It is still an issue on 4.0.0 as far as I can tell. I noticed it on my picture-elements card (doesn't do anything on hold, but tap works fine), but if I try to use a glance card, as per the original issue, the behavior is erratic. Sometimes it will perform the hold_action on tap, sometimes it will perform the tap_action on hold.

Villhellm commented 4 years ago

Double tap also seems to work fine, for what it's worth. So it's just hold_action that's having issues

jazzyisj commented 3 years ago

Issue still present with HA v0.117.2 and Swipe Card v4.0.0. Tap/double tap function fine, hold registers as a tap.

KaoruKanon commented 3 years ago

I have a similar issue. I have a swipe-card with two picture-elements. Inside the picture-elements, i have 4 button-card and i can't hold_action the button-card. It works fine on fullykiosk, chrome android and home assistant app, but actually no on chrome desktop.

ASNNetworks commented 3 years ago

This has been like this since the beginning and is only on desktop and is with all cards I believe (I tested this with custom button card myself). Android and iOS work fine. I accidentally found a workaround for this myself:

https://community.home-assistant.io/t/a-different-take-on-designing-a-lovelace-ui/162594/700?u=asnnetworks

anschein commented 3 years ago

i hava a similar problem,and also works fine on fullykiosk,but not work on PC chrome

avallini commented 3 years ago

The root cause of this issue is the same of https://github.com/bramkragten/swipe-card/issues/10. You can have a look at the comment https://github.com/bramkragten/swipe-card/issues/10#issuecomment-822094926.

Mariusthvdb commented 3 years ago

please see also https://github.com/bramkragten/swipe-card/issues/35

still open.