search

bramp / ffmpeg-cli-wrapper

Java wrapper around the FFmpeg command line tool
BSD 2-Clause "Simplified" License
1.72k stars 413 forks source link

id variable is added to support subtitle and close caption #274

Closed davinderdhindsa350 closed 3 months ago

davinderdhindsa350 commented 2 years ago

id variable is added to support subtitle and close caption hex code , so that we can find the language code using it

davinderdhindsa350 commented 2 years ago

id variable is added to support subtitle and close caption

bramp commented 2 years ago

Do we need to update any test to ensure the ID field gets populated?

davinderdhindsa350 commented 2 years ago

not needed

davinderdhindsa350 commented 2 years ago

if changes are looking ok could you please merge it , bcz I need it in my project on urgent bases

bramp commented 1 year ago

I'm sorry for not getting back sooner. But a test would be useful. None of the fixtures seem to have the "id" field a the moment, so I'd like to ensure we have a working example.

Euklios commented 3 months ago

Closing in favour of #343