search

bramp / ffmpeg-cli-wrapper

Java wrapper around the FFmpeg command line tool
BSD 2-Clause "Simplified" License
1.73k stars 413 forks source link

Add getters to FFmpegOutputBuilder and deprecate property access #320

Closed Euklios closed 8 months ago

Euklios commented 8 months ago

The goal is to allow changes to classes' internal structure and storage layout without affecting their public interface. Getters can be added to return the same information as before, while the internal might keep its information in a different way. I plan to use this in #318 to add details about each option. The getters allow me to create a seamless transition between old and new. Additionally, this makes the API more consistent within the library and other Java code.

bramp commented 8 months ago

and sorry can you briefly describe why you are making this change. What benefit does it have?

Euklios commented 8 months ago

and sorry can you briefly describe why you are making this change. What benefit does it have?

The goal is to allow changes to classes' internal structure and storage layout without affecting their public interface. Getters can be added to return the same information as before, while the internal might keep its information in a different way. I plan to use this in #318 to add details about each option. The getters allow me to create a seamless transition between old and new. Additionally, this makes the API more consistent within the library and other Java code.

Euklios commented 8 months ago

@bramp Point taken. I've reverted the deprecations on info and progress objects and kept them for the builders and options. Additionally, I kept the getters on info and progress objects as an add-on for people who prefer them or if required by frameworks.

As for versions: There shouldn't be a change impacting users (apart from deprecation notices ofc.). I'll let you decide what impact on the version number that has