search

bramp / js-sequence-diagrams

Draws simple SVG sequence diagrams from textual representation of the diagram
https://bramp.github.io/js-sequence-diagrams/
BSD 2-Clause "Simplified" License
7.82k stars 1.08k forks source link

build warns, errors #112

Closed ctzurcanu closed 9 years ago

ctzurcanu commented 9 years ago 
...
node_modules/.bin/jison src/grammar.jison -o build/grammar.js.tmp
# After building the grammar, run it through the uglifyjs to fix some non-strict issues.
# Until https://github.com/zaach/jison/issues/285 is fixed, we must do this to create valid non-minified code.
node_modules/.bin/uglifyjs \
        build/grammar.js.tmp -o build/grammar.js \
        --comments all --compress --beautify
WARN: Dropping unreachable code [build/grammar.js.tmp:88,0]
...

jspp src/diagram.js > build/diagram-grammar.js || (rm build/diagram-grammar.js && exit 127)
/bin/sh: jspp: command not found

have tried npm install JSPP -g but no fix

solutions?

bramp commented 9 years ago

Hey @ctzurcanu you need to sudo gem install jspp, instructions available https://github.com/bramp/js-sequence-diagrams#build-requirements

ctzurcanu commented 9 years ago

I'm sorry I did not read that with more attention. It built.

bramp commented 9 years ago

No problem. I've created #113 to alert you (with instructions on how to fix) if jspp is missing.

bramp commented 9 years ago

In fact, I found a way to get rid of jspp, and use a standard npm tools. Meaning Make will just install everything it needs. 73b6dc8e392a9562b88f1f4faea285435e481adb

ctzurcanu commented 9 years ago

kudos! I will try to modify your lib to use svg.js instead of raphael. hope to bring you the good news soon.