search

bramp / js-sequence-diagrams

Draws simple SVG sequence diagrams from textual representation of the diagram
https://bramp.github.io/js-sequence-diagrams/
BSD 2-Clause "Simplified" License
7.81k stars 1.08k forks source link

Proposed fix for #115 #116

Closed workroomprds closed 9 years ago

workroomprds commented 9 years ago

Changed to calculate from position of left/right-most note, rather than from first/second

workroomprds commented 9 years ago

Ah. Haven't written checks for this yet. Can confirm that it doesn't break the existing tests, and that the box is 1) consistent width in hand drawn and 2) present in simple. Works on my machine (ha).

bramp commented 9 years ago

All tests pass (but sadly that doesn't check visual layout), and visually checked myself. It looks good.