search

bramp / js-sequence-diagrams

Draws simple SVG sequence diagrams from textual representation of the diagram
https://bramp.github.io/js-sequence-diagrams/
BSD 2-Clause "Simplified" License
7.82k stars 1.08k forks source link

Distribute on npm #126

Open blakeembrey opened 9 years ago

blakeembrey commented 9 years ago

I would love to be able to use this by npm install sequence-diagrams and have it just work with Browserify, Webpack and any other JS build tools. Any chance this'll be added?

bramp commented 9 years ago

We are on bower, is that not sufficient for your use case? To be honest I never quite understood the need for both npm and bower, as they have a lot of overlap.

blakeembrey commented 9 years ago

@bramp Honestly, I haven't seen the need either and I avoid using Bower - which probably answers the question :smile: Not sure what would be involved with it, but I imagine it should be fairly straightforward. Without NPM I have to copy and paste code and dependencies and use globals.

bramp commented 9 years ago

I actually have a package on npm (for a different project). I can investigate adding this as well.

blakeembrey commented 9 years ago

Sweet, thanks :+1: Looking forward to giving it a go.

On a controversial side note, is it possible to remove underscore from the project? It's normally a pretty big/unnecessary dependency. I can do a PR for either of these if you need a hand or don't have the time.

bramp commented 9 years ago

Always happy to receive pull requests. We support underscore or lodash. We only use their functions in a handful of places, but it just made the code neater.

sergeyt commented 8 years ago

FYI I've started a PR #146 that could help to solve this issue.