search

bramp / js-sequence-diagrams

Draws simple SVG sequence diagrams from textual representation of the diagram
https://bramp.github.io/js-sequence-diagrams/
BSD 2-Clause "Simplified" License
7.81k stars 1.08k forks source link

Added version to package.json and circled actors #145

Open imrefazekas opened 8 years ago

imrefazekas commented 8 years ago

I also extended the grammar to able to express special actors drawn with ellipse.

bramp commented 8 years ago

Would you add some tests for the new oval syntax.

Also if I read this correctly, if I prefix the actor name with o- then it becomes a oval. I wonder if that is the most obvious/sensible way to do this.

imrefazekas commented 8 years ago

Also if I read this correctly, if I prefix the actor name with o- then it becomes a oval ---- yes. I use it to make differentiate actors dealing with internal communication or external as well. Whether they possess interface open to the public... The signal came from the world of UML actually or at least has a good association with the connected circle of UML. :) I do the tests asap....

imrefazekas commented 8 years ago

Test added.

bramp commented 8 years ago

You branch has conflicts. Can you rebase from master, so I can merge.

I will look over the code more, but I want to think more about this if this is the right syntax to be using.

imrefazekas commented 8 years ago

Done, hopefully the correct way...

imrefazekas commented 8 years ago

I was wondering if we could introduce some syntax to add stereotypes in some way ...

imrefazekas commented 8 years ago

Changed the prefix to () to mark it as circle. And I also introduced <> to mark it as rhombus. Better fitting syntax I think...