bramp / js-sequence-diagrams

Draws simple SVG sequence diagrams from textual representation of the diagram
https://bramp.github.io/js-sequence-diagrams/
BSD 2-Clause "Simplified" License
7.81k stars 1.08k forks source link

Changes towards modularity #146

Open sergeyt opened 8 years ago

sergeyt commented 8 years ago

This change is Reviewable

sergeyt commented 8 years ago

@bramp this PR is ready to merge, please consider to merge it and publish the package on npm.

ntotten commented 8 years ago

I would like to see this as well. Both removing the dependency and adding npm.

wollnyst commented 8 years ago

I agree. Very nice, modern setup.

Small addition, in devserver.js the static middleware must be placed after the webpack-middleware. Otherwise you'll break up dev-mode, if there's a build\sequence-diagram.js on the disk.

So put

app.use(express.static(process.cwd()));

after:

app.use(require('webpack-dev-middleware')(compiler, {
    noInfo: true,
    publicPath: config.output.publicPath,
}));

app.use(require('webpack-hot-middleware')(compiler));
sergeyt commented 8 years ago

@wollnyst thanks for tip about dev-mode, fixed!

dcousens commented 8 years ago

include fixes of issues for latest lodash 4.0

Would be great if you included this PR agnostic of the other changes, ref https://github.com/bramp/js-sequence-diagrams/issues/158

rparree commented 6 years ago

has this effort been abandoned?