bramp / js-sequence-diagrams

Draws simple SVG sequence diagrams from textual representation of the diagram
https://bramp.github.io/js-sequence-diagrams/
BSD 2-Clause "Simplified" License
7.81k stars 1.08k forks source link

Any Discourse users here? #151

Closed nskerl closed 7 years ago

nskerl commented 8 years ago

I am trying to create a Discourse plugin that uses the js-sequence-diagram library. I am running into a rendering issue where it appears the svg output is at times squashed. I suspect its due to the size of the outer container but I am having some difficulty proving that. Have you ever encountered such an issue where its sometimes rendered like this?

If anyone here is also a Discourse user you might (eventually) find this useful, and hopefully are able to help me debug it. You can view screenshots of my problem in the link below.

Thanks for the great library!

https://meta.discourse.org/t/help-debugging-sequence-diagram-plugin/40279/9?u=nskerl

nskerl commented 8 years ago

I did manage to implement this plugin in Discourse.

You can find it here: https://github.com/nskerl/discourse-sequence-diagram

I couldn't get "simple" theme to work, so its hard coded to "hand." If anyone has an idea as to why simple would render so much differently please let me know.

bramp commented 8 years ago

Very cool. Do you have an example of how simple fails?

nskerl commented 8 years ago

Yea, check this out. I dont know enough about Discourse's internals to debug this, but I am curious what, if anything, is different between these two themes that might cause this? The dimensions between the two are totally different.

image

bramp commented 7 years ago

I don't have access to the plugin on discourse, but I can't reproduce this myself. ![Uploading Screen Shot 2016-12-27 at 5.13.12 pm.png…]() I've since released a new version of the library, so if this still occurs after upgrading, then please reopen.