search

bramp / js-sequence-diagrams

Draws simple SVG sequence diagrams from textual representation of the diagram
https://bramp.github.io/js-sequence-diagrams/
BSD 2-Clause "Simplified" License
7.8k stars 1.08k forks source link

Why is there a fucknpm directory when installing via npm? #212

Open laurent22 opened 5 years ago

laurent22 commented 5 years ago 
$ ll node_modules/js-sequence-diagrams/
total 72
drwxr-xr-x   15 laurent  staff   480B 15 Mar 22:04 .
drwxr-xr-x  604 laurent  staff    19K 15 Mar 22:04 ..
-rw-r--r--    1 laurent  staff    91B 24 Aug  2016 .gitmodules
-rw-r--r--    1 laurent  staff    32B 24 Aug  2016 .npmignore
-rw-r--r--    1 laurent  staff    50B 24 Aug  2016 .travis.yml
-rw-r--r--    1 laurent  staff   1.3K 24 Aug  2016 LICENCE
-rw-r--r--    1 laurent  staff   2.7K 24 Aug  2016 Makefile
-rw-r--r--    1 laurent  staff   6.3K 24 Aug  2016 README.md
drwxr-xr-x    4 laurent  staff   128B 15 Mar 22:04 _site
-rw-r--r--    1 laurent  staff   827B 24 Aug  2016 bower.json
drwxr-xr-x    3 laurent  staff    96B 15 Mar 22:04 fonts
drwxr-xr-x    8 laurent  staff   256B 15 Mar 22:04 fucknpm
-rw-r--r--    1 laurent  staff   1.7K 15 Mar 22:04 package.json
drwxr-xr-x    8 laurent  staff   256B 15 Mar 22:04 src
drwxr-xr-x    8 laurent  staff   256B 15 Mar 22:04 test

It seems to contain the required built files:

$ ll node_modules/js-sequence-diagrams/fucknpm/
total 656
drwxr-xr-x   8 laurent  staff   256B 15 Mar 22:04 .
drwxr-xr-x  15 laurent  staff   480B 15 Mar 22:04 ..
-rw-r--r--   1 laurent  staff    29K 24 Aug  2016 diagram-grammar.js
-rw-r--r--   1 laurent  staff    26K 24 Aug  2016 grammar.js
-rw-r--r--   1 laurent  staff    23K 24 Aug  2016 grammar.js.tmp
-rw-r--r--   1 laurent  staff    83K 24 Aug  2016 sequence-diagram-min.js
-rw-r--r--   1 laurent  staff    37K 24 Aug  2016 sequence-diagram-min.js.map
-rw-r--r--   1 laurent  staff   117K 24 Aug  2016 sequence-diagram.js

Not sure if the name is a joke or something but it doesn't inspire confidence as it makes it look like the npm repo has been hacked. Is it possible to get some info about it? If it's a joke, good, but please document it.

bramp commented 5 years ago

I have no idea why that directory is named like that. How did you install this package? You can see in the Makefile that that directory should be called 'dist'.

laurent22 commented 5 years ago

I've ran npm i -s js-sequence-diagrams. I see that Boostnote, which also uses this package, has this directory too: https://github.com/BoostIO/Boostnote/blob/22d494d3f13a0d271432ee33da63c9c6683fa201/lib/main.html#L134

Maybe it's someone else who've repackaged your library?

bramp commented 5 years ago

Yes, looks like you are using a fork https://www.npmjs.com/package/js-sequence-diagrams

I only have a package published in Bower (bramp/js-sequence-diagrams) not on npm.