bramp / js-sequence-diagrams

Draws simple SVG sequence diagrams from textual representation of the diagram
https://bramp.github.io/js-sequence-diagrams/
BSD 2-Clause "Simplified" License
7.8k stars 1.08k forks source link

Master branch does not pass the lint out of the box #220

Closed comlaterra closed 2 years ago

comlaterra commented 5 years ago

First, thanks for the library. Really good.

Just cloning the project, installing all dependencies, and running make lint gives the following list of errors:

➜  js-sequence-diagrams git:(master) ✗ make lint
node_modules/.bin/jsonlint package.json -q
node_modules/.bin/jsonlint bower.json -q
node_modules/.bin/eslint src/*.js

.../js-sequence-diagrams/src/diagram.js
    6:1   error  Expected space or tab after '/*' in comment     spaced-comment
    6:10  error  'grammar' is defined but never used             no-unused-vars
    8:1   error  Missing JSDoc comment                           require-jsdoc
    9:16  error  Multiple spaces found before '='                no-multi-spaces
   10:16  error  Multiple spaces found before '='                no-multi-spaces
   14:1   error  Line 14 exceeds the maximum line length of 80   max-len
   19:3   error  Unexpected var, use let or const instead        no-var
   20:3   error  Unexpected var, use let or const instead        no-var
   27:16  error  There should be no space after '['              computed-property-spacing
   27:24  error  There should be no space before ']'             computed-property-spacing
   31:1   error  Line 31 exceeds the maximum line length of 80   max-len
   36:1   error  Line 36 exceeds the maximum line length of 80   max-len
   37:3   error  Unexpected var, use let or const instead        no-var
   38:3   error  Unexpected var, use let or const instead        no-var
   39:3   error  Unexpected var, use let or const instead        no-var
   41:11  error  Multiple spaces found before '='                no-multi-spaces
   59:14  error  Multiple spaces found before '='                no-multi-spaces
   64:19  error  Multiple spaces found before '='                no-multi-spaces
   65:19  error  Multiple spaces found before '='                no-multi-spaces
   66:19  error  Multiple spaces found before '='                no-multi-spaces
   67:19  error  Multiple spaces found before '='                no-multi-spaces
   68:19  error  Multiple spaces found before '='                no-multi-spaces
   69:19  error  Multiple spaces found before '='                no-multi-spaces
   77:18  error  Multiple spaces found before '='                no-multi-spaces
   78:18  error  Multiple spaces found before '='                no-multi-spaces
   80:18  error  Multiple spaces found before '='                no-multi-spaces
   98:12  error  Missing trailing comma                          comma-dangle
  103:10  error  Missing trailing comma                          comma-dangle
  109:10  error  Missing trailing comma                          comma-dangle
  134:1   error  Missing JSDoc for parameter 'message'           valid-jsdoc
  134:1   error  Missing JSDoc for parameter 'hash'              valid-jsdoc
  148:1   error  Line 148 exceeds the maximum line length of 80  max-len
  157:3   error  Unexpected var, use let or const instead        no-var

.../js-sequence-diagrams/src/jquery-plugin.js
   6:1  error  Expected space or tab after '/*' in comment  spaced-comment
  11:9  error  Unexpected var, use let or const instead     no-var
  12:9  error  Unexpected var, use let or const instead     no-var

.../js-sequence-diagrams/src/main.js
   8:1  error  Expected space or tab after '/*' in comment    spaced-comment
  27:1  error  Line 27 exceeds the maximum line length of 80  max-len
  29:1  error  Unexpected var, use let or const instead       no-var

.../js-sequence-diagrams/src/sequence-diagram.js
   6:1   error  Expected space or tab after '/*' in comment    spaced-comment
  13:1   error  Line 13 exceeds the maximum line length of 80  max-len
  20:1   error  Line 20 exceeds the maximum line length of 80  max-len
  27:3   error  Unexpected var, use let or const instead       no-var
  28:18  error  Missing trailing comma                         comma-dangle
  38:1   error  Line 38 exceeds the maximum line length of 80  max-len
  38:3   error  Unexpected var, use let or const instead       no-var
  43:3   error  Unexpected var, use let or const instead       no-var

.../js-sequence-diagrams/src/theme-raphael.js
    6:1   error  Expected space or tab after '/*' in comment      spaced-comment
    6:10  error  'Diagram' is defined but never used              no-unused-vars
    8:36  error  Block must not be padded by blank lines          padded-blocks
   10:3   error  Unexpected var, use let or const instead         no-var
   13:19  error  Missing trailing comma                           comma-dangle
   16:3   error  Unexpected var, use let or const instead         no-var
   19:23  error  Missing trailing comma                           comma-dangle
   22:3   error  Expected space or tab after '/**' in comment     spaced-comment
   22:3   error  Missing JSDoc @return for function               valid-jsdoc
   22:3   error  Missing JSDoc for parameter 'x1'                 valid-jsdoc
   22:3   error  Missing JSDoc for parameter 'y1'                 valid-jsdoc
   22:3   error  Missing JSDoc for parameter 'x2'                 valid-jsdoc
   22:3   error  Missing JSDoc for parameter 'y2'                 valid-jsdoc
   26:23  error  A space is required after ','                    comma-spacing
   26:26  error  A space is required after ','                    comma-spacing
   26:29  error  A space is required after ','                    comma-spacing
   30:3   error  Expected space or tab after '/**' in comment     spaced-comment
   34:3   error  Unexpected var, use let or const instead         no-var
   37:52  error  Missing trailing comma                           comma-dangle
   46:20  error  Multiple spaces found before '='                 no-multi-spaces
   47:20  error  Multiple spaces found before '='                 no-multi-spaces
   49:56  error  Missing trailing comma                           comma-dangle
   52:7   error  Unexpected var, use let or const instead         no-var
   54:27  error  Multiple spaces found before '='                 no-multi-spaces
   56:7   error  Unexpected var, use let or const instead         no-var
   57:26  error  Multiple spaces found before '='                 no-multi-spaces
   81:5   error  Missing JSDoc @return for function               valid-jsdoc
   81:5   error  Missing JSDoc for parameter 'text'               valid-jsdoc
   90:5   error  Missing JSDoc @return for function               valid-jsdoc
   90:5   error  Missing JSDoc for parameter 'text'               valid-jsdoc
   90:5   error  Missing JSDoc for parameter 'font'               valid-jsdoc
   96:7   error  Unexpected var, use let or const instead         no-var
  104:7   error  Unexpected var, use let or const instead         no-var
  111:7   error  Unexpected var, use let or const instead         no-var
  125:5   error  Missing JSDoc @return for function               valid-jsdoc
  125:5   error  Missing JSDoc for parameter 'x'                  valid-jsdoc
  125:5   error  Missing JSDoc for parameter 'y'                  valid-jsdoc
  125:5   error  Missing JSDoc for parameter 'text'               valid-jsdoc
  125:5   error  Missing JSDoc for parameter 'font'               valid-jsdoc
  125:5   error  Missing JSDoc for parameter 'align'              valid-jsdoc
  127:1   error  Line 127 exceeds the maximum line length of 80   max-len
  130:1   error  Line 130 exceeds the maximum line length of 80   max-len
  137:7   error  Unexpected var, use let or const instead         no-var
  138:7   error  Unexpected var, use let or const instead         no-var
  147:7   error  Unexpected var, use let or const instead         no-var
  158:6   error  Missing trailing comma                           comma-dangle
  161:3   error  Expected space or tab after '/**' in comment     spaced-comment
  165:3   error  Unexpected var, use let or const instead         no-var
  168:38  error  Missing trailing comma                           comma-dangle
  180:11  error  Unexpected var, use let or const instead         no-var
  192:10  error  Missing trailing comma                           comma-dangle
  196:34  error  Multiple spaces found before 'RaphaelHandTheme'  no-multi-spaces

.../js-sequence-diagrams/src/theme-snap.js
    6:1   error  Expected space or tab after '/*' in comment                                                    spaced-comment
    6:10  error  'Diagram' is defined but never used                                                            no-unused-vars
    7:1   error  Line 7 exceeds the maximum line length of 80                                                   max-len
    8:33  error  Block must not be padded by blank lines                                                        padded-blocks
   10:3   error  Unexpected var, use let or const instead                                                       no-var
   12:3   error  Unexpected var, use let or const instead                                                       no-var
   14:1   error  Line 14 exceeds the maximum line length of 80                                                  max-len
   15:19  error  Missing trailing comma                                                                         comma-dangle
   18:3   error  Unexpected var, use let or const instead                                                       no-var
   21:23  error  Missing trailing comma                                                                         comma-dangle
   24:3   error  Unexpected var, use let or const instead                                                       no-var
   26:3   error  Expected space or tab after '/**' in comment                                                   spaced-comment
   30:3   error  Unexpected var, use let or const instead                                                       no-var
   34:52  error  Missing trailing comma                                                                         comma-dangle
   45:26  error  Multiple spaces found before '='                                                               no-multi-spaces
   49:54  error  Missing trailing comma                                                                         comma-dangle
   52:13  error  Unexpected var, use let or const instead                                                       no-var
   54:33  error  Multiple spaces found before '='                                                               no-multi-spaces
   56:13  error  Unexpected var, use let or const instead                                                       no-var
   57:32  error  Multiple spaces found before '='                                                               no-multi-spaces
   60:13  error  Unexpected var, use let or const instead                                                       no-var
   68:7   error  Unexpected var, use let or const instead                                                       no-var
   82:1   error  Line 82 exceeds the maximum line length of 80                                                  max-len
   82:37  error  Missing trailing comma                                                                         comma-dangle
   84:1   error  Line 84 exceeds the maximum line length of 80                                                  max-len
   93:14  error  Missing trailing comma                                                                         comma-dangle
   98:11  error  Unexpected var, use let or const instead                                                       no-var
  104:1   error  Line 104 exceeds the maximum line length of 80                                                 max-len
  105:7   error  Unexpected var, use let or const instead                                                       no-var
  110:21  error  A function with a name starting with an uppercase letter should only be used as a constructor  new-cap
  120:7   error  Unexpected var, use let or const instead                                                       no-var
  121:7   error  Unexpected var, use let or const instead                                                       no-var
  125:1   error  Line 125 exceeds the maximum line length of 80                                                 max-len
  133:17  error  Extra space before value for key 'width'                                                       key-spacing
  134:43  error  Missing trailing comma                                                                         comma-dangle
  139:1   error  Line 139 exceeds the maximum line length of 80                                                 max-len
  140:7   error  Unexpected var, use let or const instead                                                       no-var
  141:7   error  Unexpected var, use let or const instead                                                       no-var
  146:1   error  Line 146 exceeds the maximum line length of 80                                                 max-len
  159:7   error  Unexpected var, use let or const instead                                                       no-var
  159:15  error  Use the spread operator instead of '.apply()'                                                  prefer-spread
  168:7   error  Unexpected var, use let or const instead                                                       no-var
  171:1   error  Line 171 exceeds the maximum line length of 80                                                 max-len
  174:15  error  Missing trailing comma                                                                         comma-dangle
  182:7   error  Unexpected var, use let or const instead                                                       no-var
  193:7   error  Unexpected var, use let or const instead                                                       no-var
  197:5   error  Missing JSDoc @return for function                                                             valid-jsdoc
  197:5   error  Missing JSDoc for parameter 'x'                                                                valid-jsdoc
  197:5   error  Missing JSDoc for parameter 'y'                                                                valid-jsdoc
  197:5   error  Missing JSDoc for parameter 'text'                                                             valid-jsdoc
  197:5   error  Missing JSDoc for parameter 'font'                                                             valid-jsdoc
  197:5   error  Missing JSDoc for parameter 'align'                                                            valid-jsdoc
  199:1   error  Line 199 exceeds the maximum line length of 80                                                 max-len
  202:1   error  Line 202 exceeds the maximum line length of 80                                                 max-len
  205:7   error  Unexpected var, use let or const instead                                                       no-var
  206:7   error  Unexpected var, use let or const instead                                                       no-var
  216:1   error  Line 216 exceeds the maximum line length of 80                                                 max-len
  255:3   error  Expected space or tab after '/**' in comment                                                   spaced-comment
  259:3   error  Unexpected var, use let or const instead                                                       no-var
  263:38  error  Missing trailing comma                                                                         comma-dangle
  272:7   error  Unexpected var, use let or const instead                                                       no-var
  283:7   error  Unexpected var, use let or const instead                                                       no-var
  285:6   error  Missing trailing comma                                                                         comma-dangle
  289:31  error  Multiple spaces found before 'SnapHandTheme'                                                   no-multi-spaces

.../js-sequence-diagrams/src/theme.js
    6:1   error  Expected space or tab after '/*' in comment                                                                    spaced-comment
   20:1   error  Unexpected var, use let or const instead                                                                       no-var
   22:1   error  Unexpected var, use let or const instead                                                                       no-var
   22:20  error  Multiple spaces found before '='                                                                               no-multi-spaces
   23:1   error  Unexpected var, use let or const instead                                                                       no-var
   23:20  error  Multiple spaces found before '='                                                                               no-multi-spaces
   25:1   error  Unexpected var, use let or const instead                                                                       no-var
   25:20  error  Multiple spaces found before '='                                                                               no-multi-spaces
   26:1   error  Unexpected var, use let or const instead                                                                       no-var
   28:1   error  Unexpected var, use let or const instead                                                                       no-var
   28:19  error  Multiple spaces found before '='                                                                               no-multi-spaces
   29:1   error  Unexpected var, use let or const instead                                                                       no-var
   29:19  error  Multiple spaces found before '='                                                                               no-multi-spaces
   30:1   error  Unexpected var, use let or const instead                                                                       no-var
   30:19  error  Multiple spaces found before '='                                                                               no-multi-spaces
   32:1   error  Unexpected var, use let or const instead                                                                       no-var
   32:20  error  Multiple spaces found before '='                                                                               no-multi-spaces
   33:1   error  Unexpected var, use let or const instead                                                                       no-var
   33:20  error  Multiple spaces found before '='                                                                               no-multi-spaces
   35:1   error  Unexpected var, use let or const instead                                                                       no-var
   37:1   error  Unexpected var, use let or const instead                                                                       no-var
   38:1   error  Unexpected var, use let or const instead                                                                       no-var
   38:5   error  'LINETYPE' is assigned a value but never used                                                                  no-unused-vars
   38:15  error  Multiple spaces found before '='                                                                               no-multi-spaces
   39:1   error  Unexpected var, use let or const instead                                                                       no-var
   39:5   error  'ARROWTYPE' is assigned a value but never used                                                                 no-unused-vars
   41:1   error  Unexpected var, use let or const instead                                                                       no-var
   41:18  error  Multiple spaces found before '='                                                                               no-multi-spaces
   42:1   error  Unexpected var, use let or const instead                                                                       no-var
   43:1   error  Unexpected var, use let or const instead                                                                       no-var
   44:1   error  Unexpected var, use let or const instead                                                                       no-var
   44:5   error  'ALIGN_VERTICAL_CENTER' is assigned a value but never used                                                     no-unused-vars
   46:1   error  Missing JSDoc comment                                                                                          require-jsdoc
   46:35  error  Statement inside of curly braces should be on next line                                                        brace-style
   46:61  error  Closing curly brace should be on the same line as opening curly brace or on the line after the previous block  brace-style
   51:1   error  Missing JSDoc comment                                                                                          require-jsdoc
   58:3   error  String prototype is read only, properties should not be added                                                  no-extend-native
   64:1   error  Missing JSDoc comment                                                                                          require-jsdoc
   64:10  error  'registerTheme' is defined but never used                                                                      no-unused-vars
   68:1   error  Expected space or tab after '/**' in comment                                                                   spaced-comment
   72:1   error  Missing JSDoc comment                                                                                          require-jsdoc
   76:1   error  Missing JSDoc comment                                                                                          require-jsdoc
   80:1   error  Expected space or tab after '/**' in comment                                                                   spaced-comment
   84:1   error  Missing JSDoc comment                                                                                          require-jsdoc
   94:1   error  Missing JSDoc comment                                                                                          require-jsdoc
   95:21  error  A space is required after ','                                                                                  comma-spacing
   95:24  error  A space is required after ','                                                                                  comma-spacing
   95:27  error  A space is required after ','                                                                                  comma-spacing
   98:3   error  Unexpected var, use let or const instead                                                                       no-var
  102:3   error  Unexpected var, use let or const instead                                                                       no-var
  103:3   error  Unexpected var, use let or const instead                                                                       no-var
  105:3   error  Unexpected var, use let or const instead                                                                       no-var
  106:3   error  Unexpected var, use let or const instead                                                                       no-var
  108:3   error  Unexpected var, use let or const instead                                                                       no-var
  110:37  error  Missing trailing comma                                                                                         comma-dangle
  113:3   error  Unexpected var, use let or const instead                                                                       no-var
  115:37  error  Missing trailing comma                                                                                         comma-dangle
  123:1   error  Missing JSDoc @return for function                                                                             valid-jsdoc
  123:1   error  Missing JSDoc for parameter 'x'                                                                                valid-jsdoc
  123:1   error  Missing JSDoc for parameter 'y'                                                                                valid-jsdoc
  123:1   error  Missing JSDoc for parameter 'w'                                                                                valid-jsdoc
  123:1   error  Missing JSDoc for parameter 'h'                                                                                valid-jsdoc
  126:10  error  'handRect' is defined but never used                                                                           no-unused-vars
  135:1   error  Missing JSDoc @return for function                                                                             valid-jsdoc
  135:1   error  Missing JSDoc for parameter 'x1'                                                                               valid-jsdoc
  135:1   error  Missing JSDoc for parameter 'y1'                                                                               valid-jsdoc
  135:1   error  Missing JSDoc for parameter 'x2'                                                                               valid-jsdoc
  135:1   error  Missing JSDoc for parameter 'y2'                                                                               valid-jsdoc
  138:10  error  'handLine' is defined but never used                                                                           no-unused-vars
  139:21  error  A space is required after ','                                                                                  comma-spacing
  139:24  error  A space is required after ','                                                                                  comma-spacing
  139:27  error  A space is required after ','                                                                                  comma-spacing
  143:1   error  Expected space or tab after '/**' in comment                                                                   spaced-comment
  147:1   error  Unexpected var, use let or const instead                                                                       no-var
  157:25  error  Multiple spaces found before '='                                                                               no-multi-spaces
  169:5   error  Unexpected var, use let or const instead                                                                       no-var
  170:5   error  Unexpected var, use let or const instead                                                                       no-var
  179:5   error  Unexpected var, use let or const instead                                                                       no-var
  180:5   error  Unexpected var, use let or const instead                                                                       no-var
  180:17  error  Multiple spaces found before '='                                                                               no-multi-spaces
  181:5   error  Unexpected var, use let or const instead                                                                       no-var
  181:17  error  Multiple spaces found before '='                                                                               no-multi-spaces
  182:5   error  Unexpected var, use let or const instead                                                                       no-var
  184:20  error  Multiple spaces found before '='                                                                               no-multi-spaces
  189:7   error  Unexpected var, use let or const instead                                                                       no-var
  190:7   error  Unexpected var, use let or const instead                                                                       no-var
  194:20  error  Multiple spaces found before '='                                                                               no-multi-spaces
  194:32  error  Multiple spaces found before '+'                                                                               no-multi-spaces
  199:22  error  Multiple spaces found before '+='                                                                              no-multi-spaces
  204:7   error  Unexpected var, use let or const instead                                                                       no-var
  208:16  error  Multiple spaces found before '='                                                                               no-multi-spaces
  208:28  error  Multiple spaces found before '+'                                                                               no-multi-spaces
  216:5   error  Missing JSDoc comment                                                                                          require-jsdoc
  235:7   error  Unexpected var, use let or const instead                                                                       no-var
  236:7   error  Unexpected var, use let or const instead                                                                       no-var
  238:7   error  Unexpected var, use let or const instead                                                                       no-var
  241:17  error  Multiple spaces found before '='                                                                               no-multi-spaces
  242:17  error  Multiple spaces found before '='                                                                               no-multi-spaces
  244:7   error  Unexpected var, use let or const instead                                                                       no-var
  246:31  error  Block must not be padded by blank lines                                                                        padded-blocks
  248:18  error  Multiple spaces found before '+='                                                                              no-multi-spaces
  261:7   error  Block must not be padded by blank lines                                                                        padded-blocks
  262:18  error  Multiple spaces found before '+='                                                                              no-multi-spaces
  282:9   error  Block must not be padded by blank lines                                                                        padded-blocks
  300:5   error  Unexpected var, use let or const instead                                                                       no-var
  323:20  error  Multiple spaces found before '+='                                                                              no-multi-spaces
  324:1   error  Line 324 exceeds the maximum line length of 80                                                                 max-len
  329:1   error  Line 329 exceeds the maximum line length of 80                                                                 max-len
  334:5   error  Unexpected var, use let or const instead                                                                       no-var
  336:1   error  Line 336 exceeds the maximum line length of 80                                                                 max-len
  341:5   error  Unexpected var, use let or const instead                                                                       no-var
  347:1   error  Line 347 exceeds the maximum line length of 80                                                                 max-len
  350:7   error  Unexpected var, use let or const instead                                                                       no-var
  358:18  error  Multiple spaces found before '='                                                                               no-multi-spaces
  360:1   error  Line 360 exceeds the maximum line length of 80                                                                 max-len
  364:5   error  Unexpected var, use let or const instead                                                                       no-var
  374:7   error  Block must not be padded by blank lines                                                                        padded-blocks
  385:5   error  Unexpected var, use let or const instead                                                                       no-var
  386:5   error  Unexpected var, use let or const instead                                                                       no-var
  388:5   error  Unexpected var, use let or const instead                                                                       no-var
  389:5   error  Unexpected var, use let or const instead                                                                       no-var
  393:1   error  Line 393 exceeds the maximum line length of 80                                                                 max-len
  394:1   error  Line 394 exceeds the maximum line length of 80                                                                 max-len
  397:5   error  Unexpected var, use let or const instead                                                                       no-var
  398:5   error  Unexpected var, use let or const instead                                                                       no-var
  399:5   error  Unexpected var, use let or const instead                                                                       no-var
  400:5   error  Unexpected var, use let or const instead                                                                       no-var
  401:5   error  Unexpected var, use let or const instead                                                                       no-var
  407:5   error  Unexpected var, use let or const instead                                                                       no-var
  408:5   error  Unexpected var, use let or const instead                                                                       no-var
  411:5   error  Unexpected var, use let or const instead                                                                       no-var
  412:5   error  Unexpected var, use let or const instead                                                                       no-var
  426:5   error  Unexpected var, use let or const instead                                                                       no-var
  427:5   error  Unexpected var, use let or const instead                                                                       no-var
  437:9   error  Unexpected var, use let or const instead                                                                       no-var
  438:9   error  Unexpected var, use let or const instead                                                                       no-var
  448:1   error  Line 448 exceeds the maximum line length of 80                                                                 max-len
  451:3   error  Missing JSDoc @return for function                                                                             valid-jsdoc
  451:3   error  Missing JSDoc for parameter 'box'                                                                              valid-jsdoc
  451:3   error  Missing JSDoc for parameter 'text'                                                                             valid-jsdoc
  451:3   error  Missing JSDoc for parameter 'margin'                                                                           valid-jsdoc
  451:3   error  Missing JSDoc for parameter 'padding'                                                                          valid-jsdoc
  451:3   error  Missing JSDoc for parameter 'font'                                                                             valid-jsdoc
  451:3   error  Missing JSDoc for parameter 'align'                                                                            valid-jsdoc
  455:5   error  Unexpected var, use let or const instead                                                                       no-var
  456:5   error  Unexpected var, use let or const instead                                                                       no-var
  457:5   error  Unexpected var, use let or const instead                                                                       no-var
  457:24  error  Multiple spaces found before '-'                                                                               no-multi-spaces
  458:5   error  Unexpected var, use let or const instead                                                                       no-var
  473:4   error  Missing trailing comma                                                                                         comma-dangle

✖ 313 problems (313 errors, 0 warnings)

I'll try to figure out what is going on, but so far I didn't manage to solve it. If more information is required please let me know.

P.S: I was in the process of pushing a change to make the svg responsive.

Thanks in advance!