search

bramski / angular-indexedDB

An angularjs serviceprovider to utilize indexedDB with angular
165 stars 49 forks source link

iOS/Safari 8 onupgradeneeded-bugfix #54

Closed JaZo closed 8 years ago

JaZo commented 8 years ago

This pr will resolve #15 and #41 by adding support for iOS/Safari 8.

bramski commented 8 years ago

Great! Thanks for this. Do address some of the comments. My main question though is... how do you know that this works? Ideally we'd be able to run this through the safari and iOS emulator. I'm happy if you can have a test that runs the specs in safari that can only be run on OS X.

bramski commented 8 years ago

Another PR was just merged which worked with shimIndexedDB. Is this PR still relevant?

JaZo commented 8 years ago

IndexedDB is supported on iOS 8, albeit buggy. In the way shimIndexedDB is currently implemented in this service, it will never be used on iOS 8, so this PR is still relevant. This PR solves some fixable iOS 8 quirks. I will have another look at this PR and your previous comments.

alexey-sh commented 8 years ago

How it's going? Could anybody resolve conflicts?

JaZo commented 8 years ago

I rebased/squashed/edited the commits and now it only contains a workaround for the onupgradeneeded-bug (https://bugs.webkit.org/show_bug.cgi?id=136888) and a simple fix for error messages. I do not have any tests for this, but the solution is used in other widely used packages. Unfortunately I can not guarantee that this will fix all iOS 8 quircks. After we found out that there is no easy workaround for some of the known iOS 8 quircks (see https://www.raymondcamden.com/2014/09/25/IndexedDB-on-iOS-8-Broken-Bad/), we decided to drop iOS 8 support.

bramski commented 8 years ago

Okay. Merged. Thanks!