search

bramstroker / homeassistant-powercalc

Custom component to calculate estimated power consumption of lights and other appliances
MIT License
896 stars 250 forks source link

Fix Lut validation action #2312

Closed LDprg closed 1 week ago

LDprg commented 1 week ago

After #2311 I noticed that there is a similar problem like before. The problem is not only that spaces are not correctly escaped, but () are also not properly escaped. This simply adds the code to fix this.

Hopefully then the CI/CD works out as expected.

bramstroker commented 1 week ago

@LDprg I did have a look into this. Further in this action only *.csv.gz files are relevant. So I refactored to have the git diff limit on this in the first place. That eliminates the need to add all these escape sequences. As the profile files never have spaces in the path. Could you review this change please?

bramstroker commented 1 week ago

Ok that's a much better approach. Maybe we should add double quotes just to be sure?

Where do you want to add double quotes exactly? Unsure. Could you add suggestion to the PR changes?

LDprg commented 1 week ago

@bramstroker I added the suggested change. Now every file name should be double qouted, just for safety.

bramstroker commented 1 week ago

@bramstroker I added the suggested change. Now every file name should be double qouted, just for safety.

makes sense. thanks.