search

bramton / degiro

Very basic unofficial Python API for DeGiro
BSD 3-Clause "New" or "Revised" License
52 stars 16 forks source link

Create Order #3

Open tonkolviktor opened 6 years ago

tonkolviktor commented 6 years ago

Hello bramton,

Thank you for starting and sharing this module, very nice of you! I'd like to help you to extend it if you are open to it.

Mainly, I'd like to have the option to create orders similarly to the node.js version. I would also create the necessary files for a pip module: http://python-packaging.readthedocs.io/en/latest/minimal.html This would require moving the files around a bit. Would you be open to maintain the module in the official repo? It would be much easier for the users to use the module. I noticed that the function names are not PEP compatible: https://www.python.org/dev/peps/pep-0008/#function-and-variable-names ideally, they should be renamed. My plan is to do these changes in the following days/weeks, if you are open to it we can collaborate.

V

bramton commented 6 years ago

Hi, I am happy to hear that somebody finds my work useful. My main interest was to log the value of my portfolio. Adding order placement functionality and maintaining this functionality is too much work for me at the moment. Perhaps this is something you would like to pick-up ? I could add you as collaborator to the project.

I like the idea create a pip module and to follow the PEP8 style guide.

Bram

tonkolviktor commented 6 years ago

Hello,

thanks for getting back to me, could you email me, i cannot find you address. My address is my name with a . between on gmail.

Thanks, V