search

branaway / Japid

A Java-based statically-typed fast template engine that can be used in any Java code. It has special adapter for use with the Play! Framework.
113 stars 18 forks source link

(Play! fork) production mode errors not professional as in official play! 1.2.5 #58

Open rrjanbiah opened 11 years ago

rrjanbiah commented 11 years ago

(First of all, sorry. I don't know where to report issues about your play! 1.2.x fork, so posting here.)

Your play! fork is very productive to get template errors and development speed. But, there's a problem with displaying errors in production mode (in our case with WAR).

  1. If route is not found, in official version, 404 error is displayed within overall layout. But, this fork, only a plain "URL not found" error is getting displayed without layout.
  2. If there's runtime exception, official version displays something like "This exception has been logged with id 6f64ag6nb" within layout. But, this fork, directly displays error like without layout: System error 500: play.exceptions.JavaExecutionException

When you get time, please share where to look for (which file) fixing these errors. Unfortunately, we couldn't able to figure it out yet. Thanks.

branaway commented 11 years ago

will take a look!

发自我的 iPad

在 2013-8-30，下午6:01，"R. Rajesh Jeba Anbiah" notifications@github.com 写道：

(First of all, sorry. I don't know where to report issues about your play! 1.2.x fork, so posting here.)

Your play! fork is very productive to get template errors and development speed. But, there's a problem with displaying errors in production mode (in our case with WAR).

If route is not found, in official version, 404 error is displayed within overall layout. But, this fork, only a plain "URL not found" error is getting displayed without layout.

If there's runtime exception, official version displays something like "This exception has been logged with id 6f64ag6nb" within layout. But, this fork, directly displays error like without layout: System error 500: play.exceptions.JavaExecutionException

When you get time, please share where to look for (which file) fixing these errors. Unfortunately, we couldn't able to figure it out yet. Thanks.

— Reply to this email directly or view it on GitHub.

rrjanbiah commented 11 years ago

Thanks Bing

branaway commented 11 years ago

OK, the error pages for 404 and 500 are 404.html and 500.html in the app/views/errors/ folder in your application. They're are classic Groovy pages. My play fork does not change the error reporting system. If you really want to code sophisticated error pages in Japid, you can use those two files to fire up a Japid script, like this:

// 404.html
${cn.bran.play.JapidPlayRenderer.renderWith("japidviews.error404").raw()}

Similarly, you can call into Japid to handle 500 errors with this line:

 // 500.html
${cn.bran.play.JapidPlayRenderer.renderWith("japidviews.error500", exception).raw()}

Of course you need error404.html and error500.html in the japidviews folder.

Can you verify it works in a WAR?

rrjanbiah commented 11 years ago

Thanks Bing. Will check and update.

rrjanbiah commented 11 years ago

I think, I have not communicated clearly. The problem is that on some errors like "routes not found", the 404.html file is not getting called in your fork in production mode. But, in official version, the control is coming to 404.

branaway commented 11 years ago

Really? I tested yesterday with Play server (not with Tomcat) and it worked. Did it work with Play http server in your settings?

2013/9/3 R. Rajesh Jeba Anbiah notifications@github.com

I think, I have not communicated clearly. The problem is that on some errors like "routes not found", the 404.html file is not getting called in your fork in production mode. But, in official version, the control is coming to 404.

— Reply to this email directly or view it on GitHubhttps://github.com/branaway/Japid/issues/58#issuecomment-23694916 .

rrjanbiah commented 11 years ago

We're checking in Tomcat. Will check with play server and update.

rrjanbiah commented 11 years ago

Yes, you're right. This is working in standalone version. But, not in Tomcat. If you can give us some hint like which file to check for, that will be much helpful. Thanks

branaway commented 11 years ago

It might have something to do with packaging. Let me check.

2013/9/3 R. Rajesh Jeba Anbiah notifications@github.com

Yes, you're right. This is working in standalone version. But, not in Tomcat. If you can give us some hint like which file to check for, that will be much helpful. Thanks

— Reply to this email directly or view it on GitHubhttps://github.com/branaway/Japid/issues/58#issuecomment-23698153 .

rrjanbiah commented 11 years ago

Thanks Bing.

branaway commented 11 years ago

Ha! It turned out to be a unfinished hack I had put in the ServletWrapper for Play.

Can you check out the latest Play fork from here: git@github.com:branaway/play.git and see if the problem would go away?

2013/9/3 R. Rajesh Jeba Anbiah notifications@github.com

Thanks Bing.

— Reply to this email directly or view it on GitHubhttps://github.com/branaway/Japid/issues/58#issuecomment-23706183 .

rrjanbiah commented 11 years ago

Thanks for the fix. Will check and update.

rrjanbiah commented 11 years ago

Bing, thanks a lot. This is working now. Thanks again.

branaway commented 11 years ago

Cool. Thanks for reporting. You can use the "Issues" in that project for further issues.

2013/9/4 R. Rajesh Jeba Anbiah notifications@github.com

Bing, thanks a lot. This is working now. Thanks again.

— Reply to this email directly or view it on GitHubhttps://github.com/branaway/Japid/issues/58#issuecomment-23770393 .

rrjanbiah commented 11 years ago

Sorry Bing. I'm not finding "Issues" in https://github.com/branaway/play Also, https://github.com/branaway/play/issues leads to 404.

branaway commented 11 years ago

You're right! Hmm, don't know why. Projects forked from other projects do not have Issues... Weird.

2013/9/4 R. Rajesh Jeba Anbiah notifications@github.com

Sorry Bing. I'm not finding "Issues" in https://github.com/branaway/playAlso, https://github.com/branaway/play/issues leads to 404.

— Reply to this email directly or view it on GitHubhttps://github.com/branaway/Japid/issues/58#issuecomment-23781079 .

rrjanbiah commented 11 years ago

I think, it's a setting that you have to activate http://programmers.stackexchange.com/questions/179468/forking-a-repo-on-github-but-allowing-new-issues-on-the-fork

branaway commented 11 years ago

I missed that entirely. Thanks for the tip. It's been activated now.

2013/9/4 R. Rajesh Jeba Anbiah notifications@github.com

I think, it's a setting that you have to activate http://programmers.stackexchange.com/questions/179468/forking-a-repo-on-github-but-allowing-new-issues-on-the-fork

— Reply to this email directly or view it on GitHubhttps://github.com/branaway/Japid/issues/58#issuecomment-23783634 .

rrjanbiah commented 11 years ago

Cool, thanks