search

branaway / Japid

A Java-based statically-typed fast template engine that can be used in any Java code. It has special adapter for use with the Play! Framework.
113 stars 18 forks source link

Wrong statement gets logged #64

Closed mkurz closed 10 years ago

mkurz commented 10 years ago

On line 78 and 81 in JapidPlugin.java the string of the log statement is wrong, it escapes the quotation mark (\"):

Logger.info("[Japid] version \" + JapidRenderer.VERSION + \" in PROD mode...

Therefore the following (wrong) output is written to the console:

[Japid] version " + JapidRenderer.VERSION + " in PROD mode....

To fix this, the log statement should (like on line 73) look like this:

 Logger.info("[Japid] version " + JapidRenderer.VERSION + " in PROD mode...
branaway commented 10 years ago

will fix very soon. Thanks for reporting.

2013/10/30 mkurz notifications@github.com

On line 78 and 81 in JapidPlugin.javahttps://github.com/branaway/Japid/blob/2a8a52541ec560608a42d55adbff7336873bf87a/src.japidplay/cn/bran/play/JapidPlugin.java#L78the string of the log statement is wrong, it escapes the quotation mark (\"):

Logger.info("[Japid] version \" + JapidRenderer.VERSION + \" in PROD mode...

Therefore the following (wrong) output is written to the console:

[Japid] version " + JapidRenderer.VERSION + " in PROD mode....

To fix this, the log statement should (like on line 73) look like this:

Logger.info("[Japid] version " + JapidRenderer.VERSION + " in PROD mode...

— Reply to this email directly or view it on GitHubhttps://github.com/branaway/Japid/issues/64 .

mkurz commented 10 years ago

Fixed in 0.9.37! Thanks a lot!