search

branaway / japid42

A full feaured Java-based template engine for Play2
57 stars 11 forks source link

application.conf file shipped in japid jar can cause conflicts with customer's own version #19

Open stefcl opened 11 years ago

stefcl commented 11 years ago

Hello, I have spent hours trying to find out why my application had a totally unknown secret key and why "en" was the only language available. I finally found out that the main japid jar

"japid42.japid42_2.10-0.9.9.jar"

contains an application.conf that takes precedence over mine. I strongly advise you remove this file because it's a serious and very subtle source of bugs.

branaway commented 11 years ago

Thanks for reporting and will fix it.

2013/10/29 stefcl notifications@github.com

Hello, I have spent hours trying to find out why my application had a totally unknown secret key and why "en" was the only language available. I finally found out that the main japid jar

"japid42.japid42_2.10-0.9.9.jar"

contains an application.conf that takes precedence over mine. I strongly advise you remove this file because it's a serious and very subtle source of bugs.

— Reply to this email directly or view it on GitHubhttps://github.com/branaway/japid42/issues/19 .

branaway commented 11 years ago

I have fixed that in 0.9.13. BUT since 0.9.10 Japid42 has been compatible to Play 2.2.x only. Upgrading to this version from 0.9.9 requires upgrading Play version too.

Thanks for the important catch.

2013/10/29 Bing Ran bing.ran@gmail.com

Thanks for reporting and will fix it.

2013/10/29 stefcl notifications@github.com

Hello, I have spent hours trying to find out why my application had a totally unknown secret key and why "en" was the only language available. I finally found out that the main japid jar

"japid42.japid42_2.10-0.9.9.jar"

contains an application.conf that takes precedence over mine. I strongly advise you remove this file because it's a serious and very subtle source of bugs.

— Reply to this email directly or view it on GitHubhttps://github.com/branaway/japid42/issues/19 .

stefcl commented 11 years ago

Hello, Thanks for the quick fix, I'll have to wait for the next maintenance release before upgrading to 2.2 because there is currently a bug with the closure compiler on windows platforms. In the mean time, I just manually removed application.conf from the japid jar and it seems to do the trick.