search

branaway / japid42

A full feaured Java-based template engine for Play2
57 stars 11 forks source link

Japid in play 2.2.1 breaks assets routing #22

Open stefcl opened 11 years ago

stefcl commented 11 years ago

Hello, I found my second problem to be also related to japid :-( I asked the following question on SO :

http://stackoverflow.com/questions/19923570/after-migration-to-2-2-1-all-public-assets-including-javascripts-and-css-retur

In short, after migrating to 2.2.1. All urls to my public assets were working in DEV mode only. Once in prod, it was impossible to retrieve any css, js or image file, everything resulted in a 404 erors.

I tried reproducing with a minimal play project and found out that :

1) Without the japid dependency declared it works 2) With japid referenced in build.scala it also works (doesn't seem to come from the japid jar being in classpath) 3) With GlobalSetting changed to GlobalSettingsWithJapid (with basic config) and the controller inheriting from JapidController, the issue appears!

It doesn't matter if you are rendering a japid view or a scala view, past step 3, assets serving becomes impossible in prod.

branaway commented 11 years ago

will take a good look in the next while

2013/11/14 stefcl notifications@github.com

Hello, I found my second problem to be also related to japid :-( I asked the following question on SO :

http://stackoverflow.com/questions/19923570/after-migration-to-2-2-1-all-public-assets-including-javascripts-and-css-retur

In short, after migrating to 2.2.1. All urls to my public assets were working in DEV mode only. Once in prod, it was impossible to retrieve any css, js or image file, everything resulted in a 404 erors.

I tried reproducing with a minimal play project and found out that :

1) Without the japid dependency declared it works 2) With japid referenced in build.scala it also works (doesn't seem to come from the jar itselves) 3) With GlobalSetting changed to GlobalSettingsWithJapid (with basic config) and the controller inheriting from JapidController, the issue appears!

It doesn't matter if you are rendering a japid view or a scala view, past step 3, assets serving becomes impossible in prod.

— Reply to this email directly or view it on GitHubhttps://github.com/branaway/japid42/issues/22 .

branaway commented 11 years ago

Did it happen in 2.2.0 too?

2013/11/14 Bing Ran bing.ran@gmail.com

will take a good look in the next while

2013/11/14 stefcl notifications@github.com

Hello, I found my second problem to be also related to japid :-( I asked the following question on SO :

http://stackoverflow.com/questions/19923570/after-migration-to-2-2-1-all-public-assets-including-javascripts-and-css-retur

In short, after migrating to 2.2.1. All urls to my public assets were working in DEV mode only. Once in prod, it was impossible to retrieve any css, js or image file, everything resulted in a 404 erors.

I tried reproducing with a minimal play project and found out that :

1) Without the japid dependency declared it works 2) With japid referenced in build.scala it also works (doesn't seem to come from the jar itselves) 3) With GlobalSetting changed to GlobalSettingsWithJapid (with basic config) and the controller inheriting from JapidController, the issue appears!

It doesn't matter if you are rendering a japid view or a scala view, past step 3, assets serving becomes impossible in prod.

— Reply to this email directly or view it on GitHubhttps://github.com/branaway/japid42/issues/22 .

stefcl commented 11 years ago

I can't tell because I haven't used 2.2.0. There were some bugs with assets compiling under windows that prevented me from using it at all. But I can confirm that neither this issue or the other one I posted concerning testing libraries showed up in 2.1.5.

I know that in early 2.2 versions, play team changed the way assets were resolved. It created some new issues but they are all fixed in their tracker.

branaway commented 11 years ago

Can you try 0.9.14 which has been built with 2.2.1?

2013/11/14 stefcl notifications@github.com

I can't tell because I haven't used 2.2.0. There were some bugs with assets compiling under windows that prevented me from using it at all. But I can confirm that neither this issue or the other one I posted concerning testing libraries showed up in 2.1.5.

I know that in early 2.2 versions, play team changed the way assets were resolved. It created some new issues but they are all fixed in their tracker.

— Reply to this email directly or view it on GitHubhttps://github.com/branaway/japid42/issues/22#issuecomment-28471122 .

branaway commented 11 years ago

In case you want a reference: github.com:branaway/computer-japid

2013/11/14 Bing Ran bing.ran@gmail.com

Can you try 0.9.14 which has been built with 2.2.1?

2013/11/14 stefcl notifications@github.com

I can't tell because I haven't used 2.2.0. There were some bugs with assets compiling under windows that prevented me from using it at all. But I can confirm that neither this issue or the other one I posted concerning testing libraries showed up in 2.1.5.

I know that in early 2.2 versions, play team changed the way assets were resolved. It created some new issues but they are all fixed in their tracker.

— Reply to this email directly or view it on GitHubhttps://github.com/branaway/japid42/issues/22#issuecomment-28471122 .

stefcl commented 11 years ago

I tried brievly... That did not resolve the asset routing problem. However that solved the other issue regarding test deps that get included in dist. Does it work with your computer app? (please note that the problem only shows while running the final deliverable in production mode)

branaway commented 11 years ago

hmm, I only tested with play start, not the final delivery. I'll try it later bit.

2013/11/14 stefcl notifications@github.com

I tried brievly... That did not resolve the asset routing problem. However that solved the other issue regarding test deps that get included in dist. Does it work with your computer app? (please note that the problem only shows while running the final deliverable in production mode)

— Reply to this email directly or view it on GitHubhttps://github.com/branaway/japid42/issues/22#issuecomment-28479219 .

branaway commented 11 years ago

can you try 0.9.14.1 and see if it fixes it?

2013/11/14 Bing Ran bing.ran@gmail.com

hmm, I only tested with play start, not the final delivery. I'll try it later bit.

2013/11/14 stefcl notifications@github.com

I tried brievly... That did not resolve the asset routing problem. However that solved the other issue regarding test deps that get included in dist. Does it work with your computer app? (please note that the problem only shows while running the final deliverable in production mode)

— Reply to this email directly or view it on GitHubhttps://github.com/branaway/japid42/issues/22#issuecomment-28479219 .

branaway commented 11 years ago

the computer-japid works as it should.

2013/11/14 Bing Ran bing.ran@gmail.com

can you try 0.9.14.1 and see if it fixes it?

2013/11/14 Bing Ran bing.ran@gmail.com

hmm, I only tested with play start, not the final delivery. I'll try it later bit.

2013/11/14 stefcl notifications@github.com

I tried brievly... That did not resolve the asset routing problem. However that solved the other issue regarding test deps that get included in dist. Does it work with your computer app? (please note that the problem only shows while running the final deliverable in production mode)

— Reply to this email directly or view it on GitHubhttps://github.com/branaway/japid42/issues/22#issuecomment-28479219 .

stefcl commented 11 years ago

This one seems to work at first look... Have you found anything?

branaway commented 11 years ago

yes, I had a few lines of code in the router implementation that pass asset access to the asset controller directly. The logic there might have a hole. Now l let the system to deal with asset.

2013/11/14 stefcl notifications@github.com

This one seems to work at first look... Have you found anything?

— Reply to this email directly or view it on GitHubhttps://github.com/branaway/japid42/issues/22#issuecomment-28491560 .

stefcl commented 11 years ago

Glad to know the problem is solved, I spent two days trying to figure out what was wrong with my project setup. Especially troublesome since the issue only showed in production mode... Btw you also solved the other issue I created.

branaway commented 11 years ago

Sorry for the loss of your time. I usually use "play start"directly to run in prod mode. Therefore I had not noticed the issue. Thanks a lot for reporting!

bing ran, en route

ÔÚ 2013Äê11ÔÂ14ÈÕ£¬23:22£¬stefcl notifications@github.com дµÀ£º

Glad to know the problem is solved, I spent two days trying to figure out what was wrong with my project setup. Especially troublesome since the issue only showed in production mode... Btw you also solved the other issue I created.

¡ª Reply to this email directly or view it on GitHub.

stefcl commented 11 years ago

No problem, I agree that wasn't an easy one... May I recommend you have a quick look at the deliverable from time to time? It seems to be the place where subtle things happen, remember that application.conf issue I came accross a few weeks ago. Play authors also seem to introduce quite a bunch of serious changes for what you'd expect to be simple maintenance releases.

branaway commented 11 years ago

Everything happens on the class path in a packaged runtime environment whereas it runs off the file system otherwise. Thus the subtleties.

bing ran, en route

ÔÚ 2013Äê11ÔÂ14ÈÕ£¬23:54£¬stefcl notifications@github.com дµÀ£º

No problem, I agree that wasn't an easy one... May I recommend you have a quick look at the deliverable from time to time? It seems to be the place where subtle things happen, remember that application.conf issue I came accross a few weeks ago. Play authors also seem to introduce quite a bunch of serious changes for what you'd expect to be simple maintenance releases.

¡ª Reply to this email directly or view it on GitHub.

stefcl commented 11 years ago

Are you going to release a more official fix?

branaway commented 11 years ago

I have some other things in work, but none related to this issue. Do you have anything particular in mind?

2013/11/19 stefcl notifications@github.com

Are you going to release a more official fix?

— Reply to this email directly or view it on GitHubhttps://github.com/branaway/japid42/issues/22#issuecomment-28788548 .

stefcl commented 11 years ago

No, except that anyone trying japid in the current play version (2.2.1) will certainly run into major issues unless you tell them about your new version on the wiki page.

branaway commented 11 years ago

Oh I see. I'll update the documentations.

2013/11/19 stefcl notifications@github.com

No, except that anyone trying japid in the current play version (2.2.1) will certainly run into major issues unless you tell them about your new version on the wiki page.

— Reply to this email directly or view it on GitHubhttps://github.com/branaway/japid42/issues/22#issuecomment-28789918 .