search

branchpanic / stockpile

A Minecraft mod all about storage.
MIT License
10 stars 5 forks source link

Trash upgrade only works with hoppers #88

Open NolanSyKinsley opened 4 years ago

NolanSyKinsley commented 4 years ago

The trash upgrade only works with hoppers for me, trying to manually input the items by hand or when using the hat and pressing G it does not delete the extra items.

branchpanic commented 4 years ago

I initially did this intentionally because I didn't want players to accidentally delete items (since neither the barrel hat nor manual input give confirmation). However, I think that it'd be a good idea to enable what you're asking for here as a config option. That's one of my goals for the next release and although I'm totally swamped by one class in particular right now, I'm hoping I can get on it soon.

Do you think the config options "enable deleting items by hand" and "enable deleting items by barrel hat" under a "Trash Upgrade" category would address this, or should I reconsider my default? Thanks for opening an issue!

NolanSyKinsley commented 4 years ago

Probably a much bigger task, but I would consider a configuration GUI that each barrel could have opened, probably while holding the screwdriver, that would allow configuration of each individual barrel.

Either that or I would reconsider your default. Every barrel/drawer mod that I know of all void from hand and when interacting with inventory without a config option at all. Installing the void upgrade is the act of saying "I know everything over the max will be deleted, go ahead" without any further information or conformation being provided past that point other than a symbol on the front of the barrel, or in your case the yellow text.

branchpanic commented 4 years ago

Installing the void upgrade is the act of saying "I know everything over the max will be deleted, go ahead" without any further information or conformation being provided past that point other than a symbol on the front of the barrel, or in your case the yellow text.

This is a really good point and I agree with you on that. I'll still keep global and barrel-specific config options as part of the plan, but after the effort required to enable such functionality it probably should indeed be enabled by default :D