branchseer / DeskGap

A cross-platform desktop app framework based on Node.js and the system webview
https://deskgap.com/
MIT License
1.83k stars 75 forks source link

setMenu(null) throw an error #25

Closed Armaldio closed 4 years ago

Armaldio commented 5 years ago

image

branchseer commented 5 years ago

Could you show the full code that produces this error?

Armaldio commented 5 years ago
const { app, BrowserWindow } = require('deskgap');

app.once('ready', () => {
  let mainWindow = new BrowserWindow({
    width : 1280,
    height: 720,
  });

  mainWindow.loadURL('https://discordapp.com/channels/@me');
  mainWindow.setMenu(null);

  // mainWindow.setMenu(null);
  // mainWindow.maximize();

  mainWindow.on('closed', () => {
    mainWindow = null;
  });
});
branchseer commented 5 years ago

Fixed in https://github.com/patr0nus/DeskGap/commit/297972830b43d6f345db52722c938ebbe3e487a9.