search

brancz / prometheus-example-app

Go app that exposes metrics about its HTTP handlers.
MIT License
138 stars 78 forks source link

seems unnecessary replace usage left in go.mod #13

Open Morty-luo opened 1 year ago

Morty-luo commented 1 year ago

It seems that module github.com/brancz/prometheus-example-app at now directly depends on v1.3.0 of github.com/prometheus/client_golang.
https://github.com/brancz/prometheus-example-app/blob/master/go.mod#L6

github.com/prometheus/client_golang v1.3.0

So, replace usage left in go.mod makes no sense. Should it be dropped?
https://github.com/brancz/prometheus-example-app/blob/master/go.mod#L10

replace github.com/prometheus/client_golang => github.com/prometheus/client_golang v1.3.0
brancz commented 1 year ago

Huh I don’t even understand how that got there. Absolutely! Do you want to open a PR to remove it?

Morty-luo commented 1 year ago

Simply run go mod edit -dropreplace=github.com/prometheus/client_golang should be able to remove it.