search

brandaid / dancenetwork

Front-End Presentational Markup
0 stars 0 forks source link

Hide numbers when overlapping headline #10

Closed jeremymansfield closed 9 years ago

jeremymansfield commented 9 years ago

You can hide the numbers on mobile so there are no issues with overlaying or competing with the headers.

nerdpruitt commented 9 years ago

I have them hiding at 480px right now. So you don't want them to overlap the headers at all?

jeremymansfield commented 9 years ago

OK, that's fine. I've only checked on desktop and I guess safari doesn't squeeze down that far. Sounds great (and looks great) so far. I've got a stomach bug, so I'm a little foggy right now.

jeremymansfield commented 9 years ago

Now that they've seen this "live" they don't like the lines to the left of the headline with the overlapping of the numbers. I've suggested we hide the numbers at that breakpoint and not remove the line next to the headline. Waiting for confirmation. No action yet.

nerdpruitt commented 9 years ago

Cool. All the numbers are about the same width, so we can definitely set a breakpoint for right before they overlap.

jeremymansfield commented 9 years ago

Let's go ahead and set a breakpoint for right before they overlap. I don't want to remove the colored bar line. It gives more visual interest to me, and I like it for mobile.

nerdpruitt commented 9 years ago

Fixed by: https://github.com/brandaid/dancenetwork/commit/6225c3acebddcd12cb00c8fe89bd4cb4cea9cafe