Closed AnmolSinha1201 closed 4 years ago
Make sure that your .csproj file has the following tag in a PropertyGroup
<Version>1.0</Version>
(change the 1.0 to whatever version you want)
Is there any way it can pick up the version directly from .csproj
?
Edit: I looked at your JS, it indeed is executing regex on the version file (which defaults to project file). Maybe this is a bug. Any way I can help?
Yes - this is a tag you put into the .csproj file!
On Wed, Apr 1, 2020 at 10:20 PM Anmol Sinha notifications@github.com wrote:
Is there any way it can pick up the version directly from .csproj?
β You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rohith/publish-nuget/issues/22#issuecomment-607627215, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGKWZ6BMXVWWIYODWLMGSTRKQODBANCNFSM4LZAZNNQ .
-- John Azariah
m +1 425 614 8158 e john.azariah@gmail.com t @johnazariah http://twitter.com/johnazariah
It's already present in the .csproj
file. For some reason, it doesn't pick up the tag
I just saw your repo, and the project file seems like it has the tag. Your yaml file doesn't refer anything weird for the regex or anything, so it should get picked up...
Looks like you tried '/' and '\' as separators as well...maybe all the cd
ing you're doing in the previous steps changes something?
Can you create yourself a fork of the publish-nuget repo and refer to that instead, and add some diagnostics to look at the text of the csproj file?
I can't seem to run actions on your repo...
Thanks for the help @johnazariah
@AnmolSinha1201 I forked your repo & commented out the dotnet test
that was failing & it worked as expected.
I saw your attempts to resolve the issue by escaping slash characters but that should be taken care by the script
I'm not sure what's wrong here but I'll keep this one open & maybe add some additional info to the error messages & some logs that might help
Great work, mate! :)
Thanks for this action -- very useful!
On Thu, Apr 2, 2020, 21:04 Rohith Reddy notifications@github.com wrote:
I forked your repo & commented out the dotnet test that was failing & it worked as expected.
I saw your attempts to resolve the issue by escaping slash characters but that should be taken care by the script
I'm not sure what's wrong here but I'll keep this one open & maybe add some additional info to the error messages & some logs that might help
β You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rohith/publish-nuget/issues/22#issuecomment-608216899, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGKWZ4BIDOBKPY36VTX3SDRKVN3RANCNFSM4LZAZNNQ .
@johnazariah @rohith The tests actually broke yesterday. I had to update the code but couldn't update the tests. I'll fix the tests as soon as possible.
@rohith @johnazariah I just checked publish-nuget, it works fine now. I'll close the issue.
This is what I am using in my Action yml
But I get
My Repo :
https://github.com/AnmolSinha1201/Surrogate