search

brandedoutcast / publish-nuget

📦 GitHub action to automate publishing NuGet packages when project version changes
https://github.com/marketplace/actions/publish-nuget
MIT License
197 stars 101 forks source link

Make dotnet check cross-platform #3

Closed cuzzlor closed 4 years ago

cuzzlor commented 4 years ago

The command command is not available outside powershell on windows, so the dotnet check fails: https://github.com/cuzzlor/password-check/commit/c72e77d93f3d52b8e924547ba9937aee01b4b2ee/checks?check_suite_id=365776138

brandedoutcast commented 4 years ago

🤝 Thanks for the PR, it was previously not possible due to the execSync as it would throw an error if we did dotnet --version without dotnet but spawnSync doesn't do that & I like the log for missing nuget_key

cuzzlor commented 4 years ago

Works like a charm... https://github.com/cuzzlor/password-check/commit/1d295f84fc689ad3b885e8bef083c54b75725cd9/checks?check_suite_id=366246974

Thanks @rohith it was a pleasure working with you!