brandedoutcast / publish-nuget

📦 GitHub action to automate publishing NuGet packages when project version changes
https://github.com/marketplace/actions/publish-nuget
MIT License
197 stars 101 forks source link

when nuget package in "Validating" status #32

Closed mindfocus closed 4 years ago

mindfocus commented 4 years ago

upload package error


##[error]😭 error: Response status code does not indicate success: 409 (A package with ID 'sabre.net' and version '1.0.4' already exists and cannot be modified.).
/home/runner/work/_actions/rohith/publish-nuget/v2/index.js:23
        throw new Error(msg)
        ^

Error: error: Response status code does not indicate success: 409 (A package with ID 'sabre.net' and version '1.0.4' already exists and cannot be modified.).
    at Action._printErrorAndExit (/home/runner/work/_actions/rohith/publish-nuget/v2/index.js:23:15)
    at Action._pushPackage (/home/runner/work/_actions/rohith/publish-nuget/v2/index.js:73:18)
    at IncomingMessage.<anonymous> (/home/runner/work/_actions/rohith/publish-nuget/v2/index.js:109:30)
    at IncomingMessage.emit (events.js:215:7)
    at endReadableNT (_stream_readable.js:1184:12)
    at processTicksAndRejections (internal/process/task_queues.js:80:21)
mindfocus commented 4 years ago

I think it's just a tip more than an error, right?

LegendaryB commented 4 years ago

Experienced the same. Looks like it is really just an warning. But I would prefer when it would be logged as warning under actions. So that I can also see that the packages which are published afterwards are pushed. What do you think @brandedoutcast

brandedoutcast commented 4 years ago

@mindfocus @LegendaryB I'm not quite sure in what scenario you get this but the action should've just skipped creating a package altogether when there's a package with same name & version. Also the --skip-duplicate flag should've handled it even if there was an existing package