search

brandedoutcast / publish-nuget

📦 GitHub action to automate publishing NuGet packages when project version changes
https://github.com/marketplace/actions/publish-nuget
MIT License
197 stars 101 forks source link

Why is PACKAGE_NAME not grabbed from the PackageId msbuild property in the csproj file ? #33

Closed softlion closed 4 years ago

softlion commented 4 years ago

Why is PACKAGE_NAME not grabbed from the PackageId msbuild property in the csproj file ?

It is simpler.

  <PropertyGroup>
    <PackageId>Softlion.NotionSharp</PackageId>
   ...
brandedoutcast commented 4 years ago

It's just easier to set PACKAGE_NAME input.

Interpreting would involve checking the csproj file & maybe nuspec file & any place where PackageId can be configured but you're welcome to open a PR if you feel strongly about it

softlion commented 4 years ago

Well you are picking the version from the csproj file already

brandedoutcast commented 4 years ago

Yup that resulted in adding VERSION_FILE_PATH, VERSION_REGEX & VERSION_STATIC inputs to the action & I'm hesitant on bloating it with more such inputs if it tries to interpret the PackageId

Considering we don't change PackageId unlike the version I think it's pretty minimal effort to just add a single line to the action with PACKAGE_NAME what do you think?