search

brandedoutcast / publish-nuget

📦 GitHub action to automate publishing NuGet packages when project version changes
https://github.com/marketplace/actions/publish-nuget
MIT License
197 stars 101 forks source link

[BUG] Does not use the VERSION_STATIC property #46

Open csharpfritz opened 3 years ago

csharpfritz commented 3 years ago

Describe the bug Does nothing with the version number assigned through VERSION_STATIC

Failed Action Log URL (Required) A URL to the failed action log.

To Reproduce Steps to reproduce the behavior:

  1. Assign value to VERSION_STATIC

Expected Behavior NuGet package should be created with the assigned version

Environment:

itniels commented 3 years ago

I ran into this issue as well, I have the Action create the version, and would like to set it manually for the NuGet package.

Kritner commented 2 years ago

Yeah I'm a bit unclear on how this is supposed to be integrated, or if this should just be more of a boolean flag?

GitVersioning just as an example seems to already "come up with" the version itself, and it produces a package file with that version accordingly (assuming doing GeneratePackageOnBuild). I'm tinkering around a bit with this build action right now and running into that problem.

Seems like some examples that show off the use of this feature may be worthwhile, like how it all fits together. Though based on some of the issues and prs in this repo, perhaps it's been abandoned?