brandedoutcast / publish-nuget

📦 GitHub action to automate publishing NuGet packages when project version changes
https://github.com/marketplace/actions/publish-nuget
MIT License
197 stars 101 forks source link

F# Support #5

Closed sanchez closed 4 years ago

sanchez commented 4 years ago

I would love to be able to publish my F# projects using this library! (Currently it can't find the project)

brandedoutcast commented 4 years ago

~Sure, I'll get it done 👍~

It's done, re-open this if you're facing any issues

sanchez commented 4 years ago

You are a legend, however F# using PackageVersion instead of Version (so your version regex is out of date), I have also noticed if I do a series of commits and then push it will sometimes fail to detect the change and upload (I believe this is due to the use of the diff to get the version difference)

brandedoutcast commented 4 years ago

You are a legend, however F# using PackageVersion instead of Version (so your version regex is out of date)

The regex looks at Version as it's the most commonly used one, do you actually intend for a Version & PackageVersion divergence? 😕

I have also noticed if I do a series of commits and then push it will sometimes fail to detect the change and upload (I believe this is due to the use of the diff to get the version difference)

Got it, a fix is on the way 🔧 #6