search

brandedoutcast / publish-nuget

📦 GitHub action to automate publishing NuGet packages when project version changes
https://github.com/marketplace/actions/publish-nuget
MIT License
197 stars 101 forks source link

Output versioned file name #52

Open luizbon opened 3 years ago

luizbon commented 3 years ago

Fix #43 Adding the PackageVersion parameter to the pack command will make the output file to respect it.

elrhomariyounes commented 3 years ago

I think this PR will fix also the #46

sergeyshaykhullin commented 3 years ago

@brandedoutcast This is a critical bug, i just pushed a wrong version =(

drusellers commented 3 years ago

@brandedoutcast agreed with @sergeyshaykhullin - is there anything you need to merge this?

drusellers commented 3 years ago

@sergeyshaykhullin I merged your pr into my own fork drusellers/publish-nuget@master FWIW

sergeyshaykhullin commented 3 years ago

@drusellers Can you please create a fixed release version for this changes?

drusellers commented 3 years ago

@sergeyshaykhullin drusellers/publish-nuget@v3 note that I've changed the syntax a bit to match other github actions and I now pass the version tag to the build as well as the publish. Feel free to open issues. :)

gonace commented 3 years ago

@sergeyshaykhullin drusellers/publish-nuget@v3 note that I've changed the syntax a bit to match other github actions and I now pass the version tag to the build as well as the publish. Feel free to open issues. :)

Hi, would it be possible to merge the VERSION_STATIC functionality into your fork?

I created a fork of this project since I needed this functionality right away, sad to see the "same" project having multiple implementations, but what to do. 🤷‍♂️

Our implementation that also supports VERSION_STATIC: laget-se/publish-nuget@v2.6.7

AraHaan commented 3 years ago

Mind opening this PR to https://github.com/Elskom/publish-nuget/ this is my fork as well 🤣 because I needed some other changes on top of the other prs open here?