Open sergeyshaykhullin opened 3 years ago
@sergeyshaykhullin those logs expired.
I think a simple fix for this is to remove .forEach(fn => fs.unlinkSync(fn))
since usually people add nupkg
's and snupkg
's to their .gitignore
. If they did not that is their fault if they use an action that commits them to the repository. Wait no I will just change that line to depend on the projectFile
variable that it points to on that path.
No, because if you will not delete previous nuget files you will try to push them again
So basically I guess one way to fix that is to nuke them after publish.
@AraHaan No, i suggest to
Each build step has its own directory for .nuget files and do not delete previous
Randomly generate directories foreach GitHub Action run
So if you have:
- uses: brandedoutcast/publish-nuget@v2
...
- uses: brandedoutcast/publish-nuget@v2
...
You will have:
.../random/path/1/*.nuget
.../random/path/2/*.nuget
It means that:
_pushPackage
should generate random directory-o { directory }
https://github.com/brandedoutcast/publish-nuget/blob/c12b8546b67672ee38ac87bea491ac94a587f7cc/index.js#L62push { directory }/*.nuget
https://github.com/brandedoutcast/publish-nuget/blob/c12b8546b67672ee38ac87bea491ac94a587f7cc/index.js#L67readDirSync('{ directory }')
https://github.com/brandedoutcast/publish-nuget/blob/c12b8546b67672ee38ac87bea491ac94a587f7cc/index.js#L64Also, as i know, this repo is abandoned
@drusellers What do you think about this changes?
I got a better idea and updated #61 accordingly. It might be a bit of a hack however.
Alright merged into my fork.
Describe the bug Each build and push step deletes all nuget packages from previous one
Failed Action Log URL (Required) https://github.com/appany/AppAny.Quartz.EntityFrameworkCore.Migrations/runs/1913414360?check_suite_focus=true
To Reproduce
Expected Behavior Each build step has its own directory for .nuget files and do not delete previous
The workaround is to reorder steps
Here is the problem https://github.com/brandedoutcast/publish-nuget/blob/c12b8546b67672ee38ac87bea491ac94a587f7cc/index.js#L58
Environment: