search

brandedoutcast / publish-nuget

📦 GitHub action to automate publishing NuGet packages when project version changes
https://github.com/marketplace/actions/publish-nuget
MIT License
197 stars 101 forks source link

Publish multiple projects #9

Closed drjaydenm closed 4 years ago

drjaydenm commented 4 years ago

At the moment, I can only see a way to support a single project being published per repo (unless I was to change the version format for every package to avoid collisions).

Would it be possible to allow multiple project/package support? Or maybe just a way to disable the git tagging step for every project after the first one?

brandedoutcast commented 4 years ago

I see the problem, supporting multiple projects/packages shouldn't be hard, I'll see what can be done

To disable git tagging after main project the action needs to know which is the main project. This info can be provided via the yaml config. Does it sound good or do you prefer some other way to do it?

drjaydenm commented 4 years ago

Yeah that sounds like it should work, maybe as simple as a boolean flag to toggle the git tagging check/step. At the moment, my config looks like this

- name: Publish Project.Core
  uses: rohith/publish-nuget@v1
  with:
    project_dir: Project.Core
    nuget_key: ...
- name: Publish Project.Extension
  uses: rohith/publish-nuget@v1
  with:
    project_dir: Project.Extension
    nuget_key: ...

In the second project pack/push it blows up due to the tag existing from the previous step

brandedoutcast commented 4 years ago

Okay, if you're setting up the action per project then a flag is the simplest solution. I'll add it right away, but it'll be an opt-in to NOT TAG in order to prevent breaking existing builds as tagging a release is more common behavior

brandedoutcast commented 4 years ago

Use v2 to customize tagging & version detection & reopen / create new issue if it doesn't work as expected