brandly / angular-youtube-embed

:tv: Embed a YouTube player with a simple directive
http://brandly.github.io/angular-youtube-embed/
MIT License
510 stars 147 forks source link

package.js added to create an package on atmospherejs #103

Open andredeloliveira opened 8 years ago

andredeloliveira commented 8 years ago

Hello! I am a Meteor.js developer and I found your solution very useful for my application. Really, it is a greate solution. I am opening this pull request to add the package.js file into the portal, so it can be reviewed and updated in the Atmosphere.js portal.

Thank you again for creating this!

Cheers, Andre.

brandly commented 8 years ago

hey andre! i didn't know about Atmosphere.js.

looking at the package.js, why are dependencies, like lodash, listed? it looks like they're also listed on atmospherejs.com.

it seems like we should remove those

andredeloliveira commented 8 years ago

Hey! Well, I was following bower.json dependencies. They are listed on atmospherejs.com because they are in thepackage.js file as well. If lodash is not a a dependency we can remove it, otherwise we have to keep it. :)

brandly commented 8 years ago

oh i see! the bower.json devDependencies aren't needed to use this directive in your project. they are needed to run tests against this project, so they're for development, not the end user.

i think they can be taken out for Atmosphere. thanks!

andredeloliveira commented 8 years ago

Oh, I understand now. Well, we can remove lodash then as the others are dependencies to actually use the directive :).

Thanksk for letting me know about it :smile:

brandly commented 8 years ago

we should be fine without angular-mocks as well

andredeloliveira commented 8 years ago

Cool! We can do that then.