search

brandly / angular-youtube-embed

:tv: Embed a YouTube player with a simple directive
http://brandly.github.io/angular-youtube-embed/
MIT License
510 stars 147 forks source link

Feature request: Angular 2 support #112

Open deepakgd opened 8 years ago

deepakgd commented 8 years ago

Implement this for angular2 application

brandly commented 8 years ago

i figured someone would ask sooner or later. i haven't touched angular 2 at all yet. really, i haven't touched angular in general for quite a while.

i'll get around to this eventually tho

pull requests are welcomed :four_leaf_clover: :laughing:

deepakgd commented 8 years ago

Sure I will try to do On Mar 29, 2016 9:59 PM, "Matthew Brandly" notifications@github.com wrote:

i figured someone would ask sooner or later. i haven't touched angular 2 at all yet. really, i haven't touched angular in general for quite a while.

i'll get around to this eventually tho

pull requests are welcomed [image: :four_leaf_clover:] [image: :laughing:]

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/brandly/angular-youtube-embed/issues/112#issuecomment-202985848

brandly commented 8 years ago

reading thru this migration guide, there are probably a few hurdles here to get over:

if anyone sees this and would like to help, let me know! i could make a branch, with the goal of Angular 2 support, and then others could open pull requests towards that new branch :star2:

aluanhaddad commented 8 years ago

@brandly I'd be happy to contribute when I get some time. I have strong TypeScript knowledge and experience, and I'm familiar with setting up various build configurations.

That said, there's no requirement that angular2 applications be written in TypeScript at all. You could use ES5.1 but that would be rather unpleasant in this context. If you have familiarity with Babel, you are free to use that. They can be mixed-and-matched and you can migrate to TypeScript by simply renaming your files and introducing type annotations. The main hurdle is understanding decorators but they are not particularly complicated.

brandly commented 8 years ago

thanks @aluanhaddad! do you know any Angular 2 directives that, in your opinion, are built and set up well? i'd like to poke around an existing project and see how things work

aluanhaddad commented 8 years ago

I'm definitely early on in the learning process as far as Angular 2 itself. Some of the Material Design components look very promising and they have good documentation. For example, this is their list component: https://github.com/angular/material2/tree/master/src/components/list

aluanhaddad commented 8 years ago

@hughred22 @brandly I started some preliminary work on this a while back but angular 2 has been in flux for a very long time. Things do seem to be stabilizing so I'll try to take a look at it this weekend.

brandly commented 8 years ago

thanks for the update @aluanhaddad! i really appreciate the help!

i just pushed a branch (with no changes) up to GitHub. that way, even if you make some progress, feel free to open PRs towards that branch 🌟

aluanhaddad commented 8 years ago

Right on. That's what I'll do. :heart:

hughred22 commented 7 years ago

Is there any update on this? Any ETA for an Angular 2 version of this great component ? Angular 2 is pretty stable now.

tagniam commented 7 years ago

+1

aluanhaddad commented 7 years ago

I want to apologize. I have had very little time of late and have not been able to work on this.

Additionally Angular 2 (now just Angular) has changed dramatically since I began using it.

The advent of AOT (Ahead Of Time compilation) and the expectation that even the simplest Angular libraries both run under AOT and ship additional metadata files has been very unfortunate as it severely complicates development. Furthermore, writing an AOT compliant application or library implies severe limitations and, more significantly, implies writing non-standard code in a language derived from TypeScript that has runtime behavior that is not compliant with the future of ECMAScript (and thereby is no longer TypeScript.

For what it is worth, at this point, Angular 2/4 is not something I would recommend using in general. It has grown disproportionately complex.

While I still do Angular development on occasion, I have not had the time to work on this and I would welcome anyone who wants to take up the endeavor to do so.

brandly commented 7 years ago

Don't feel bad!! To be honest I really haven't used Angular in like 2 years, so I'm not at all up to date on Angular 2 or 4 or whatever.

If someone wants to use this in new versions of Angular, hopefully they'll contribute. Otherwise, I guess this repo will be stuck in Angular 1.

Have a good weekend!

On Sat, May 27, 2017 at 12:03 PM Aluan Haddad notifications@github.com wrote:

I want to apologize. I have had very little time of late and have not been able to work on this.

Additionally Angular 2 (now just Angular) has changed dramatically since I began using it.

The advent of AOT (Ahead Of Time compilation) and the expectation that even the simplest Angular libraries both run under AOT and ship additional metadata files has been very unfortunate as it severely complicates development. Furthermore, writing an AOT compliant application or library implies severe limitations and, more significantly, implies writing non-standard code in a language derived from TypeScript that has runtime behavior that is not compliant with the future of ECMAScript (and thereby is no longer TypeScript.

For what it is worth, at this point, Angular 2/4 is not something I would recommend using in general. It has grown disproportionately complex. While the Angular.

While I still do Angular development on occasion, I have not had the time to work on this and I would welcome anyone who wants to take up the endeavor to do so.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/brandly/angular-youtube-embed/issues/112#issuecomment-304460808, or mute the thread https://github.com/notifications/unsubscribe-auth/AAyF2O9u5jGRx7pvSin5VaGmraz1t9REks5r-ElmgaJpZM4H6aEb .

arLevi commented 7 years ago

are there any updates ?

LanderBeeuwsaert commented 6 years ago

+1

aluanhaddad commented 6 years ago

@LanderBeeuwsaert as I said I'm no longer working on it. I've no plans to use Angular 2/4/5 at present. Feel free to take this up.

LanderBeeuwsaert commented 6 years ago

:-), (won't take you up on the offer) But thanks for responding!