search

brandly / angular-youtube-embed

:tv: Embed a YouTube player with a simple directive
http://brandly.github.io/angular-youtube-embed/
MIT License
510 stars 147 forks source link

API event messages are not received #165

Closed rushdykamel closed 3 years ago

rushdykamel commented 3 years ago

It seems that only recently, event messages stopped to be received from iframe_API.. after debugging I found that the directive overrides Youtube player object ID.. which it seems preventing the API from sending messages to the client. after removing that, it worked fine.. I created this PR to fix it https://github.com/brandly/angular-youtube-embed/pull/164

LoyalPotato commented 3 years ago

Worked for me. Also had some problems where the events weren't being triggered. Could you tell me how you went about debugging the problem?

rushdykamel commented 3 years ago

I'm glad it worked for you.. and yes it was blocking all the events... I started debugging with using native JS to call youtube iframe API.. then created my own directive and used bits and pieces from angular-youtube-embed library.. trying to find out what makes it break! and it was that line..

galdil commented 3 years ago

Will someone approve this fix? Or u have just cloned the library?

brandly commented 3 years ago

@rushdykamel thanks! Good work!

How do you all use this library? Install from npm? Copy it into some vendor directory?

I haven't touched this repo in a long time, so I'll have to figure out how to get a new release published. Bear with me!

rushdykamel commented 3 years ago

Hi @brandly Thank you for merging the PR. Yes, I use npm to install the library.. you will need to publish a new NPM version.

brandly commented 3 years ago

v1.3.2 out now ✨