WIP: Drop parallel's apply for futurized counterpart - Githubissues

brandmaier / semtree

Recursive Partitioning for Structural Equation Models

https://brandmaier.github.io/semtree/

GNU General Public License v3.0

13 stars 11 forks source link

WIP: Drop parallel's apply for futurized counterpart #31

Closed octomike closed 3 years ago

octomike commented 3 years ago

This simple PR replaces all occurrances of parallel::parXapply with their future.apply counterparts. With this change you can:

enable users to use their own (parallel) execution strategy (the demos use plan(multisession))
stop creating static cluster objects and stop carrying them around
remove some checks and code duplication
(imho) ignore the seed demo, because future.seeds = T should take care of the RNG state

I think this branch still needs:

A hint for new users that, by default, future.apply does things sequentially (README or just demos?)
updated docs/ and man/ (how do you do that here exactly?)

I'm happy to include additional changes and discuss the general idea of course. Let me know :)

brandmaier commented 3 years ago

This is awesome and a great improvement to the parallelizability of semtree! Thanks!