search

brando90 / MathNet-large-scale-Mathematics-Dataset-for-Machine-Learning

1 stars 0 forks source link

method get_names return type #65

Open theosech opened 7 years ago

theosech commented 7 years ago

When generating variables from a list using get_names, the return type is a tuple. This is appropriate when the number of variables is greater than 1 as one can write for example: x, y, z = (1,3,5), but if there is only one variable then the variable is matched to a tuple i.e. x = (1,). I was going to change it in the framework but I don't know if that is going to mess up unit tests etc. For now in my problem if I only want one variable I just get the first element of the tuple. However I am still getting errors in the unit tests because of it. Thanks in advance. @brando90

brando90 commented 7 years ago

@theosech feel free to go ahead and change things in the framework and add appropriate unit tests if they are missing. You can always check with me or @hairuoguo if your worried about something but it would be nice that at least some of you are familiar with the framework's internals and help contribute/improve it.