Open brando90 opened 1 year ago
I fixed it on my testing by adding the line "args.min_examples_in_class = 20".
Does it work after that?
I fixed it on my testing by adding the line "args.min_examples_in_class = 20".
where did you do this? Can you please get into the habit of pushing your changes? I see nothing.
args.min_examples_in_class = 20
also can we have documentation somewhere (ideally a line before) seemingly arbitrary things we have to specify in the config functions so that we know why we are doing this? It's really a nightmare to come back 3 months later to see random things like this.
Also, your mds arg parse should be aimed to have as many of these params set so that the user can run an experiment with the minimum amount of effort him to modify things. @patricks-lab
Per pytorch-mds we have that
'--min_examples_in_class' => 'Classes that have less samples will be skipped'
so that means that if we set args.min_examples_in_class = args.k_shot + args.k_eval we ensure that each of the n ways sampled in our n-way k-shot task has enough samples for both the support and query sets.
I will soon add that line to the epsiodic and batch dataloaders with the comment.