search

brandon-a / CIS-22C-Group-Project

Using different data structures to organize USDA nutritional facts.
0 stars 0 forks source link

toUpper #31

Closed theorangepotato closed 8 years ago

theorangepotato commented 8 years ago

When we search by secondary key, we should convert the search string to all caps so that someone who is searching doesn't have to hold shift or use caps lock or anything.

I'm not sure exactly whose job this is, but its @ashalan1998 's function, so I'm tagging you.

Jasko-A commented 8 years ago

Yes that is a very good idea On Dec 2, 2015 9:46 PM, "theorangepotato" notifications@github.com wrote:

When we search by secondary key, we should convert the search string to all caps so that someone who is searching doesn't have to hold shift or use caps lock or anything.

I'm not sure exactly whose job this is, but its @ashalan1998 https://github.com/ashalan1998 's function, so I'm tagging you.

— Reply to this email directly or view it on GitHub https://github.com/brandon-a/CIS-22C-Group-Project/issues/31.

ashalan1998 commented 8 years ago

Just added that. If I understood correctly, I changed it so that typing in "apple" will search for "APPLE".

Jasko-A commented 8 years ago

Did we do the same thing for wheb we add an item On Dec 2, 2015 10:11 PM, "ashalan1998" notifications@github.com wrote:

Closed #31 https://github.com/brandon-a/CIS-22C-Group-Project/issues/31.

— Reply to this email directly or view it on GitHub https://github.com/brandon-a/CIS-22C-Group-Project/issues/31#event-481054883 .

theorangepotato commented 8 years ago

Awesome. And you are right, @Jasko-A , we should do the same on input.

ashalan1998 commented 8 years ago

No, but I can do that.

ashalan1998 commented 8 years ago

Ok, did the same for input. When adding Food objects, entering in "apple" will be saved as "APPLE".

Jasko-A commented 8 years ago

Awesome go ahead and do that On Dec 2, 2015 10:13 PM, "ashalan1998" notifications@github.com wrote:

No, but I can do that.

— Reply to this email directly or view it on GitHub https://github.com/brandon-a/CIS-22C-Group-Project/issues/31#issuecomment-161527983 .

theorangepotato commented 8 years ago

@ashalan1998 I don't see the commit yet?

ashalan1998 commented 8 years ago

Thats weird, I did commit twice.

On Wed, Dec 2, 2015 at 10:20 PM, theorangepotato notifications@github.com wrote:

@ashalan1998 https://github.com/ashalan1998 I don't see the commit yet?

— Reply to this email directly or view it on GitHub https://github.com/brandon-a/CIS-22C-Group-Project/issues/31#issuecomment-161529141 .