search

brandon-patterson / chemist

A virtual lab assistant
MIT License
0 stars 0 forks source link

Add Element Enum #15

Closed brandon-patterson closed 4 years ago

brandon-patterson commented 4 years ago

This PR adds a basic Element enum, with methods to go to/from atomic number, symbol, and name.

(I've supported internationalization on the names/symbols, though in doing so, I've started to wonder whether including these context-specific methods in the enum is the right call. I'm thinking it should be OK for now, but I figured I'd point out my misgivings.)

I've only supported the "official" element names (scraped from wikipedia), so alternative/temporary names (e.g. Unun*ium) aren't currently supported. I figure that level of support can be implemented in the FutureTM

zspatter commented 4 years ago

Is the check for brandon-patterson.chemist the Azure CI? I can't seem to figure out what the required check is waiting on.

brandon-patterson commented 4 years ago

Yeah, I'm pretty sure Azure does a test merge before it runs the CI pipeline. It's getting hung up on the CHANGELOG merge conflict. (That's pretty normal for a changelog. You get good at resolving simple conflicts pretty fast.)

I'll fix the changelog and merge when we've got green tests.