search

brandon1024 / find

A find-in-page extension for Chrome and Firefox that supports regular expressions.
https://chrome.google.com/webstore/detail/find%2B-regex-find-in-page/fddffkdncgkkdjobemgbpojjeffmmofb
GNU General Public License v3.0
409 stars 53 forks source link

Really large page becomes unresponsive when I try to search #310

Closed belousa closed 4 years ago

belousa commented 4 years ago

Really large page (a Grok view for a large generated class, 17.5 K lines) becomes unresponsive when I try to search.

brandon1024 commented 4 years ago

Could you attach more details? Link to the page, the regular expression you're using, and any other details would be helpful. Closing this issue for now, you can reopen once there's more details.

belousa commented 4 years ago

Here is a sample, very large file in Linux code. Typing anything in the search window never produces any finds. I can't quite repro the "unresponsive" part.

https://raw.githubusercontent.com/torvalds/linux/851ca779d110f694b5d078bc4af06d3ad37169e8/drivers/gpu/drm/amd/include/asic_reg/nbio/nbio_6_1_sh_mask.h

brandon1024 commented 4 years ago

Yeah, this is not something that find+ is going to support. If you need to search through very large pages/files, it's more appropriate to use a more efficient tool (grep, an editor, etc).

belousa commented 4 years ago

Any way to mention this in ReadMe? Or produce a banner at runtime that the page is too big?

brandon1024 commented 3 years ago

This has been documented on the extension page: This tool will struggle with significantly large pages. In these cases, using another tool might be more appropriate.