Using Enter to search second time doesn't work

brandon1024 / find

A find-in-page extension for Chrome and Firefox that supports regular expressions.

https://chrome.google.com/webstore/detail/find%2B-regex-find-in-page/fddffkdncgkkdjobemgbpojjeffmmofb

GNU General Public License v3.0

409 stars 53 forks source link

Using Enter to search second time doesn't work #325

Closed Hemloc closed 4 years ago

Hemloc commented 4 years ago

Issue Description

After you have performed a search for something, then close and reopen the search bar, the previous search text is still there, and if you press Enter, nothing happens. No results are returned, not even zero.

It would also be nice if after pressing Enter for the second search it continued from the current position, but Issue 323 was opened for that :)

Steps to Reproduce

Open search bar using Ctrl+Shift+F.
Enter any text.
Press ESC.
Open search bar again using Ctrl+Shift+F.
Press Enter.

brandon1024 commented 4 years ago

Hi @Hemloc, thanks for your interest :-) I recall looking into this a while back and had no luck, it's a strange defect and difficult to debug.

I've been really busy with my day job the past little while and have neglected this project a bit, but I promise to pick this up sometime soon.

Thanks for using Find+!

Hemloc commented 4 years ago

I did forget to mention I was using Firefox 79.0.

And cool, at least it still does work! :D

brandon1024 commented 4 years ago

Fixed! Will be opening a PR shortly.