search

brandon1024 / find

A find-in-page extension for Chrome and Firefox that supports regular expressions.
https://chrome.google.com/webstore/detail/find%2B-regex-find-in-page/fddffkdncgkkdjobemgbpojjeffmmofb
GNU General Public License v3.0
409 stars 53 forks source link

[Feature request] Dark mode support #337

Open OmarNamis opened 3 years ago

OmarNamis commented 3 years ago

Issue Description

I hope you can add a dark mode option for the extension's UI.

This documentation page should help: https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme

brandon1024 commented 3 years ago

I've actually already tried to implement this in the past, I think about a year or two ago. The reason I didn't go through with it in the end was because there was a 1px border around the extension popup that I couldn't control that inherited the color of the browser, so it made the extension popup look rather ugly.

I haven't tried these changes in newer versions of Chrome/Firefox though, maybe that has since been fixed. I'll leave this issue open until I have a chance to look into it on newer browser versions.

peter-lyons-kehl commented 8 months ago

Thank you for Find+.

Yes please for Dark mode. "Ugly" is good enough.