search

brandon1024 / find

A find-in-page extension for Chrome and Firefox that supports regular expressions.
https://chrome.google.com/webstore/detail/find%2B-regex-find-in-page/fddffkdncgkkdjobemgbpojjeffmmofb
GNU General Public License v3.0
414 stars 54 forks source link

[Feature request] Add option to disable omnibox #345

Closed nerivera closed 3 years ago

nerivera commented 3 years ago

I often find myself searching for something starting with the word "find" in the address bar, only to have Find+ treat my search as a regex. This is incredibly annoying, and as I don't ever use the omnibox for regex searches (I always use the keyboard shortcut), I would like a way to disable it, but I couldn't find an option on Find+ or on my browser. Please add this option.

brandon1024 commented 3 years ago

Thanks for your interest @nerivera. This is a duplicate of https://github.com/brandon1024/find/issues/312, which was closed because there's not really much I can do. Here's my reasoning from that ticket:

I looked into this in a while back when another user asked a similar question, and determined that it is not possible to disable the Omnibox integration programatically.

One option is to change the omnibox keyword for the extension to "find-ext", or similar, but there are a lot of users that use the Omnibox feature and it would be confusing to them if the keyword changed. If enough users want this change, then I'll implement it, but for now I'm going to keep the existing functionality.

The extension omnibox features are defined through the extension's manifest file, which is static and can't be modified programmatically. This is what prevents me from modifying the omnibox behavior.

Perhaps in a later version we'll rename the keyword if we get more requests for this, but for now it'll stay the same.

nerivera commented 3 years ago

Here's an idea: make two different versions of the extension on two different branches, one with omnibox, and one without. Since this might be confusing for people searching for the extension on the Chrome Web Store or Firefox Add-ons, you could release the branch with omnibox on the extension stores and provide the branch without omnibox on GitHub for users to install manually, maybe with a wiki page linked from the README to go with it explaining how to install it. Or, if you're okay with having two different versions of the extension on the extension stores, just release both and explain the difference in the descriptions.

brandon1024 commented 3 years ago

To be completely honest, I'm not interested in doing that for a number of reasons. Managing extensions in the store takes time. Deploying the extension to the Chrome Web Store and the Firefox add-ons store takes time. What you propose would mean that I would need to maintain four extensions, instead of two. That means that there are four sources of feedback as well, and it makes it harder to track the analytics of the extension usage. Additionally, as changes are introduced into the development branch I have to integrate them into two branches at release time. All of this means more effort on my part, which isn't compelling to do when a very small subset (two or three out of nearly ten thousand active users) want this feature.

If you're really interested in removing the omnibox functionality, you can simply clone this repository locally, update the manifest, and then install the extension yourself.

Kaminate commented 1 year ago

If you're really interested in removing the omnibox functionality, you can simply clone this repository locally, update the manifest, and then install the extension yourself.

My steps to do this if anyone else wants to try: https://github.com/Kaminate/find-no-omnibox

mcgwiz commented 1 year ago

Feel free to use this, which was built from 79e3acb7cc0bba62d45c0cbb9ba9cafc5a208da5 with the single change of adding a + to the omnibox keyword: https://notes.mcgwiz.com/assets/attachments/66e7ce7c1c3d41488a5d-2.2.3.xpi