search

brandon1024 / find

A find-in-page extension for Chrome and Firefox that supports regular expressions.
https://chrome.google.com/webstore/detail/find%2B-regex-find-in-page/fddffkdncgkkdjobemgbpojjeffmmofb
GNU General Public License v3.0
413 stars 54 forks source link

Inputfield is black and font color also #390

Closed Aybee closed 1 year ago

Aybee commented 1 year ago

Issue Description

I wondered, why suddenly the whole input dropdown was black, but I found the reason.

Screen-2022-12-14_00-54-52

Steps to Reproduce

It depends on the setting of my Firefox. Happens, when I uncheck this checkbox:

Screen-2022-12-14_00-49-37 It might be related to this error here: https://github.com/brandon1024/find/blob/4795d28b22fd98681199e2295e8efe7bfbb8df78/docs/help.css#L49-L56 If you set a background-color, then you need to make sure you set a color as well. You cannot rely on the user setting white as the background color and black as the foreground color. This makes the help page also not readable for me.

Bildschirmfoto am 2022-12-14 um 00 56 06

brandon1024 commented 1 year ago

Hey! Thanks for your interest in find+. I'm pretty hands off these days, but will happily merge any pull request for this.

Aybee commented 1 year ago

Yes, it's a shortcomming that Firefox has no integrated regex-search, that's why I've been interested in find+ for a long time.

I'm a webdeveloper but unfortunately I've no time to figure out how to develope browser addons. I'm pretty good at CSS, HTML and JS. Maybe if I find the time I can take a look at the help files help.css and index.html if that would help.

If you tell me where I can find the CSS for the search box and how to debug it, I can also take a look at this.

brandon1024 commented 1 year ago

Most of the CSS for the popup is here. The CSS for the help page is here. Check out this page for testing extensions.

brandon1024 commented 1 year ago

Fixes will be available in the upcoming release, version 2.2.3 :tada: