Improvements to text color and background color - Githubissues

brandon1024 / find

A find-in-page extension for Chrome and Firefox that supports regular expressions.

https://chrome.google.com/webstore/detail/find%2B-regex-find-in-page/fddffkdncgkkdjobemgbpojjeffmmofb

GNU General Public License v3.0

413 stars 54 forks source link

Improvements to text color and background color #397

Closed pzhlkj6612 closed 1 year ago

pzhlkj6612 commented 1 year ago

Fixes #390; fixes #392

Changes Proposed in this Pull Request:

Set text color of the "User Guide" page to "black".
Set the background-color of popup to "white".
Darken the text of search index in popup.

Additional Comments and Documentation:

Tested in the following two browsers on Windows 10 Pro 21H2 (19044.2486):

Google Chrome Version 112.0.5579.0 (Official Build) canary (64-bit)
Firefox Nightly 111.0a1 (2023-02-04) (64-bit) with user settings about the color (in "Settings" - "Language and Appearance" - "Colors"):
- "Text" is "white",
- "Background" is "black",
- "Use system colors" is unchecked.

Comparison:

Overall changes in this PR:

20230206-Firefox-Extension-Find+-color-overall

For "Darken the text of search index in popup" (a4d0b52ea91198f7dc92d8e7d9f0b6bf46d4557a):

20230206-Firefox-Extension-Find+-color-search_index-Firefox-Chrome

The webpage I was opening:

Browser Toolbox — Firefox Source Docs documentation

brandon1024 commented 1 year ago

I'll take a look after work :-) Thanks for your contribution!