brandon1024 / find

A find-in-page extension for Chrome and Firefox that supports regular expressions.
https://chrome.google.com/webstore/detail/find%2B-regex-find-in-page/fddffkdncgkkdjobemgbpojjeffmmofb
GNU General Public License v3.0
419 stars 54 forks source link

Check if the zip utility is installed before any actions #408

Open pzhlkj6612 opened 8 months ago

pzhlkj6612 commented 8 months ago

Changes Proposed in this Pull Request:

Additional Comments and Documentation:

Before:

$ zip
Command 'zip' not found, but can be installed with:
sudo apt install zip

$ ./build.sh -v '1.4.4'
./build.sh: Creating the build directory structure under .../find/.build...
mkdir: created directory '.../find/.build'
mkdir: created directory '.../find/.build/chr'
mkdir: created directory '.../find/.build/moz'
./build.sh: Copying project source files to build directory...
./build.sh: Updating version number in manifest to 1.4.4...
./build.sh: Packaging extension for Chrome...
./build.sh: line 109: zip: command not found
./build.sh: Packaging extension for Firefox...
./build.sh: line 116: zip: command not found

After:

$ zip
Command 'zip' not found, but can be installed with:
sudo apt install zip

$ ./build.sh -v '1.4.4'
Error: missing 'zip' utility.

.

pzhlkj6612 commented 3 months ago

@brandon1024 , a ping from late summer.