brandonbloom
commented
8 years ago Hi Michael,
It's very exciting to hear that Fipp is now the default in Cider! Thanks for taking on this work.
I might not have a chance for a few days to pull down the code and play with it. I'll take a super quick look at the code now and make some comments. While it's OK by me if the engine code gets a little hairy, I'd like to do my best to keep the pretty-document printer code as clean as possible, as it's a good reference for people writing printers for non-edn.
Cheers, Brandon
cichli
Hi, first of all, thanks for the great (and fast!) library :-).
Both options are analogous to (and default to)
*print-length*and*print-level*respectively.I also took a stab at improving the benchmark, using
test.checkto generate sample data usingany-printable. Additionally, I've switched to using a stubbedWriterimplementation instead ofwith-out-strto try and minimise any overhead.Here are results for the new benchmark, both before and after this change is applied - the impact is reasonably negligible for normal usage (i.e. when
:print-length/:print-levelare not set). Please do try and verify these results locally!Notes on the implementation:
:print-lengthis implemented by using ataketransducer to limit the number of lines returned by the relevantvisit-*methods, iff:print-lengthis set....is appended to the collection being printed if its length exceeds:print-length.:print-levelis implemented similarly to in Clojure itself - each time we call one of the relevantvisit-*methods, we decrement its value, iff:print-levelis set. This is done by using a new instance ofEdnPrinterrather than the dynamic binding approach used in Clojure.#is printed instead of the contents of the collection if the current:print-levelis negative.Motivation for this change: we now use
fippas the default pretty-printer in CIDER, but would like a way to prevent accidental printing of infinitely long or recursive structures :-). Let me know if there's anything I've missed or you think I should change.