search

brandonbloom / fipp

Fast Idiomatic Pretty Printer for Clojure
525 stars 44 forks source link

:nest :indent arg should default to 2 #34

Closed cichli closed 8 years ago

cichli commented 8 years ago

In primitives.md it's stated that indent is optional in :nest nodes, and should default to 2. I've altered the code to make this true, and added tests for this + the default offset value of 0 for :align nodes.

brandonbloom commented 8 years ago

Good catch. Forgive me for nitpicking, but you could you please: 1) Not change the existing code for align and 2) Not use the cond->> macro for nest? I don't have a strong objection to that macro, I just don't think it's particularly readable and I like to avoid both negation and additional code churn when I can.

cichli commented 8 years ago

Done & done; no problem at all :-).

brandonbloom commented 8 years ago

Thanks!