search

brandonbloom / fipp

Fast Idiomatic Pretty Printer for Clojure
525 stars 44 forks source link

JDK 11 Support #50

Closed willcohen closed 5 years ago

willcohen commented 6 years ago

core.rrb-vector's next release will include a fix for JDK 11 compatibility, at which point fipp should be updated as well.

tirkarthi commented 6 years ago

Thanks @willcohen I was just testing it. The clojurescript dev profile dependency in project.clj should also be updated to 1.10.238 since the current version is incompatible with JDK 8 causing compilation errors. It will be also helpful to add Travis to catch these errors in future.

JDK 11 build failure due to core.rrb-vector : https://travis-ci.org/tirkarthi/fipp/jobs/402077194

brandonbloom commented 6 years ago

Assuming this is just a dependency upgrade, happy to make the change for the next release. Send a message when that time comes, since I'm not moving to JDK 11 myself immediately.

middlesphere commented 5 years ago

Java 11 is out! Please, upgrade this lib. Thanks.

brandonbloom commented 5 years ago

I'm not in a rush. Waiting on the rrb release. If this affects you, please send a pull request when rrb is updated.

brandonbloom commented 5 years ago

OK continuing discussion over at https://github.com/brandonbloom/fipp/pull/51

brandonbloom commented 5 years ago

Deployed 0.6.13

philomates commented 5 years ago

Hello, would it be possible to bump to rrb-vector 0.0.13 to address some additional warnings? We bumped midje to fipp 0.6.13 in https://github.com/marick/Midje/pull/447#issuecomment-430987730 and have since had to pin the latest version of rrb-vector to get rid of some warnings: https://github.com/marick/Midje/pull/448

Thanks!