brandonbloom / fipp

Fast Idiomatic Pretty Printer for Clojure
525 stars 44 forks source link

Many math warning aginst Clojure 1.10 #52

Closed arichiardi closed 5 years ago

arichiardi commented 5 years ago

Hi there,

I get the following in fipp against the new Clojure 1.10:

Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/nodes.clj:88:11 - call: public static boolean clojure.lang.Numbers.lt(long,java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/nodes.clj:176:16 - call: public static long clojure.lang.Numbers.shiftLeft(long,java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/nodes.clj:177:16 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_minus(long,java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/nodes.clj:178:16 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_minus(java.lang.Object,java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/nodes.clj:179:48 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_dec(java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/nodes.clj:179:25 - call: public static long clojure.lang.Numbers.shiftRight(java.lang.Object,java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/nodes.clj:217:23 - call: public static long clojure.lang.Numbers.shiftLeft(long,java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/nodes.clj:235:29 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_add(long,java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/nodes.clj:250:11 - call: public static boolean clojure.lang.Numbers.equiv(java.lang.Object,long).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/nodes.clj:259:20 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_minus(java.lang.Object,long).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/nodes.clj:269:22 - call: public static boolean clojure.lang.Numbers.equiv(java.lang.Object,long).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/nodes.clj:273:31 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_minus(java.lang.Object,long).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/nodes.clj:275:42 - call: public static long clojure.lang.Numbers.shiftLeft(long,java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/nodes.clj:287:36 - call: public static boolean clojure.lang.Numbers.equiv(java.lang.Object,long).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/nodes.clj:290:29 - call: public static boolean clojure.lang.Numbers.equiv(java.lang.Object,long).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/nodes.clj:308:27 - call: public static boolean clojure.lang.Numbers.equiv(java.lang.Object,long).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/transients.clj:187:35 - call: public static boolean clojure.lang.Numbers.isZero(java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/transients.clj:198:41 - call: public static boolean clojure.lang.Numbers.isZero(java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/transients.clj:223:15 - call: public static boolean clojure.lang.Numbers.isZero(java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/transients.clj:257:28 - call: public static boolean clojure.lang.Numbers.isZero(java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:270:26 - call: public static boolean clojure.lang.Numbers.isPos(java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:327:29 - call: public static boolean clojure.lang.Numbers.isPos(java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:341:36 - call: public static boolean clojure.lang.Numbers.isZero(java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:356:35 - call: public static boolean clojure.lang.Numbers.isPos(java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:387:34 - call: public static boolean clojure.lang.Numbers.equiv(java.lang.Object,long).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:392:29 - call: public static boolean clojure.lang.Numbers.isPos(java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:400:39 - call: public static boolean clojure.lang.Numbers.isPos(java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:807:30 - call: public static boolean clojure.lang.Numbers.isPos(java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1001:24 - call: public static boolean clojure.lang.Numbers.isZero(java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1205:26 - call: public static boolean clojure.lang.Numbers.isPos(java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:559:32 - call: public static boolean clojure.lang.Numbers.isZero(java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1253:5 - call: public static boolean clojure.lang.Numbers.equiv(java.lang.Object,java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1282:9 - call: public static boolean clojure.lang.Numbers.isZero(java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1292:13 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_minus(java.lang.Object,long).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1314:14 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_add(java.lang.Object,java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1317:14 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_add(java.lang.Object,java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1318:30 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_dec(java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1318:24 - call: public static java.lang.Number clojure.lang.Numbers.quotient(java.lang.Object,long).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1318:19 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_inc(java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1318:14 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_minus(java.lang.Object,java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1320:7 - call: public static boolean clojure.lang.Numbers.lte(java.lang.Object,long).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1323:11 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_add(java.lang.Object,java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1323:7 - call: public static boolean clojure.lang.Numbers.lte(java.lang.Object,long).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1324:21 - call: public static boolean clojure.lang.Numbers.isZero(java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1345:22 - call: public static boolean clojure.lang.Numbers.isZero(java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1365:47 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_minus(java.lang.Object,long).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1366:42 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_minus(long,java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1378:51 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_minus(java.lang.Object,long).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1390:16 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_add(java.lang.Object,java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1393:16 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_add(java.lang.Object,java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1394:32 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_dec(java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1394:26 - call: public static java.lang.Number clojure.lang.Numbers.quotient(java.lang.Object,long).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1394:21 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_inc(java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1394:16 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_minus(java.lang.Object,java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1396:9 - call: public static boolean clojure.lang.Numbers.lte(java.lang.Object,long).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1399:13 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_add(java.lang.Object,java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1399:9 - call: public static boolean clojure.lang.Numbers.lte(java.lang.Object,long).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1448:35 - call: public static boolean clojure.lang.Numbers.gt(long,java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1449:29 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_minus(long,java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1451:33 - call: public static boolean clojure.lang.Numbers.gte(java.lang.Object,long).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1453:54 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_minus(long,java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1455:27 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_add(java.lang.Object,java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1462:32 - call: public static boolean clojure.lang.Numbers.isPos(java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1462:56 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_dec(java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1463:42 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_inc(java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1471:7 - call: public static boolean clojure.lang.Numbers.equiv(java.lang.Object,long).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1476:37 - call: public static long clojure.lang.Numbers.shiftLeft(long,java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1477:25 - call: public static boolean clojure.lang.Numbers.isZero(java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1477:35 - call: public static long clojure.lang.Numbers.shiftLeft(long,java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1484:37 - call: public static long clojure.lang.Numbers.shiftLeft(long,java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1485:25 - call: public static boolean clojure.lang.Numbers.isZero(java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1485:35 - call: public static long clojure.lang.Numbers.shiftLeft(long,java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1488:42 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_minus(java.lang.Object,long).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1491:40 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_add(java.lang.Object,java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1496:18 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_add(java.lang.Object,java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1502:18 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_minus(java.lang.Object,java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1522:30 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_add(java.lang.Object,java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1562:14 - call: public static java.lang.Object clojure.lang.Numbers.max(java.lang.Object,long).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1572:19 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_add(long,java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1573:19 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_minus(long,java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1592:52 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_add(java.lang.Object,long).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1655:32 - call: public static boolean clojure.lang.Numbers.isZero(java.lang.Object).
Boxed math warning, cider/inlined_deps/fipp/v0v6v13/corerrb_vector/v0v0v12/clojure/core/rrb_vector/rrbt.clj:1859:30 - call: public static boolean clojure.lang.Numbers.isPos(java.lang.Object).

It is a bit verbose because inlined in cider and what it seems like is that some reflection mechanism has changed and now warnings are reported from core.rrb.

Maybe a bump will be enough?

jafingerhut commented 5 years ago

I am a bit surprised if these warnings are new with Clojure 1.10 vs. Clojure 1.9. I get what appear to be the same warnings when using Clojure 1.9 and 1.10-beta3 to do 'lein check' on the core.rrb-vector project at version 0.0.12, the one embedded inside fipp.

Alex Miller did release a version 0.0.13 of core.rrb-vector that changes the warning settings inside core.rrb-vector source code that does quiet down these warnings, but I don't think that was because Clojure 1.10 changed anything about which ones were issued.

arichiardi commented 5 years ago

Not sure about the hows then. Just way too verbose for not reporting it :smile:

trevor commented 5 years ago

I see this too in fipp v0.6.13, v0.6.12 does not return this. Clojure 1.10.0-RC1, javac 10.0.1.

trevor commented 5 years ago

Perhaps this is related to the updated dependency org.clojure/core.rrb-vector

https://github.com/brandonbloom/fipp/commit/1d5b74

trevor commented 5 years ago

Looks like there's a new version of org.clojure/core.rrb-vector 0.0.13 which fixes this.

https://github.com/clojure/core.rrb-vector/commits/master

brandonbloom commented 5 years ago

Fixed: https://github.com/brandonbloom/fipp/commit/2bef22d3f47139c1ee60e7ec367fa31de9429c22

arichiardi commented 5 years ago

:+1: